Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_role_definition - Increase the continuous count of post delete checks #18208

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Sep 1, 2022

There are still a couple of test failures for the azurerm_role_definition on TC with following error message:

=== RUN   TestAccRoleDefinition_basic
=== PAUSE TestAccRoleDefinition_basic
=== CONT  TestAccRoleDefinition_basic
testing_new.go:84: Error running post-test destroy, there may be dangling resources: "azurerm_role_definition.test" still exists
--- FAIL: TestAccRoleDefinition_basic (131.26s)
FAIL

From the API sequence, it appears that even though the GET API returns 404 for 6 times (each time has a 10s delay), the last check on its existance is still possible to return a 200. The underlying reason behind this might due to the ARM cache, but increasing the check during might still help?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧾

@katbyte katbyte merged commit 97720b6 into hashicorp:main Sep 2, 2022
@github-actions github-actions bot added this to the v3.21.0 milestone Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This functionality has been released in v3.21.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants