-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource : azurerm_api_management_gateway_host_name_configuration
#17962
New Resource : azurerm_api_management_gateway_host_name_configuration
#17962
Conversation
azurerm_api_management_gateway_host_name_configuration
"is_client_certificate_requested": { | ||
Type: pluginsdk.TypeBool, | ||
Optional: true, | ||
}, | ||
|
||
"is_http2_enabled": { | ||
Type: pluginsdk.TypeBool, | ||
Default: true, | ||
Optional: true, | ||
}, | ||
|
||
"is_tls10_enabled": { | ||
Type: pluginsdk.TypeBool, | ||
Optional: true, | ||
}, | ||
|
||
"is_tls11_enabled": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is is redundant when the property ends in enabled, and likely requested to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"is_client_certificate_requested": { | |
Type: pluginsdk.TypeBool, | |
Optional: true, | |
}, | |
"is_http2_enabled": { | |
Type: pluginsdk.TypeBool, | |
Default: true, | |
Optional: true, | |
}, | |
"is_tls10_enabled": { | |
Type: pluginsdk.TypeBool, | |
Optional: true, | |
}, | |
"is_tls11_enabled": { | |
"request_client_certificate_enabled": { | |
Type: pluginsdk.TypeBool, | |
Optional: true, | |
}, | |
"http2_enabled": { | |
Type: pluginsdk.TypeBool, | |
Default: true, | |
Optional: true, | |
}, | |
"tls10_enabled": { | |
Type: pluginsdk.TypeBool, | |
Optional: true, | |
}, | |
"tls11_enabled": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katbyte thanks for your feedback:). Fixed.
86ac612
to
529d300
Compare
529d300
to
6d33917
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎲
This functionality has been released in v3.21.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Support API Management Gateway Host Name Configuration. API spec is here.
Test Results: