Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource : azurerm_api_management_gateway_host_name_configuration #17962

Merged

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Aug 11, 2022

Support API Management Gateway Host Name Configuration. API spec is here.

Test Results:

PASS: TestAccApiManagementGatewayHostNameConfiguration_basic (5271.51s)
PASS: TestAccApiManagementGatewayHostNameConfiguration_requiresImport (4982.43s)
PASS: TestAccApiManagementGatewayHostNameConfiguration_complete (4883.23s)
PASS: TestAccApiManagementGatewayHostNameConfiguration_update (5338.44s)

@sinbai sinbai changed the title [New Resource] azurerm_api_management_gateway_host_name_configuration - Support API management gateway host name configuration New Resource : azurerm_api_management_gateway_host_name_configuration Aug 15, 2022
Comment on lines 63 to 79
"is_client_certificate_requested": {
Type: pluginsdk.TypeBool,
Optional: true,
},

"is_http2_enabled": {
Type: pluginsdk.TypeBool,
Default: true,
Optional: true,
},

"is_tls10_enabled": {
Type: pluginsdk.TypeBool,
Optional: true,
},

"is_tls11_enabled": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is is redundant when the property ends in enabled, and likely requested to?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"is_client_certificate_requested": {
Type: pluginsdk.TypeBool,
Optional: true,
},
"is_http2_enabled": {
Type: pluginsdk.TypeBool,
Default: true,
Optional: true,
},
"is_tls10_enabled": {
Type: pluginsdk.TypeBool,
Optional: true,
},
"is_tls11_enabled": {
"request_client_certificate_enabled": {
Type: pluginsdk.TypeBool,
Optional: true,
},
"http2_enabled": {
Type: pluginsdk.TypeBool,
Default: true,
Optional: true,
},
"tls10_enabled": {
Type: pluginsdk.TypeBool,
Optional: true,
},
"tls11_enabled": {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte thanks for your feedback:). Fixed.

@sinbai sinbai force-pushed the apimanagement/host_name_configurations branch from 86ac612 to 529d300 Compare August 30, 2022 07:55
@sinbai sinbai force-pushed the apimanagement/host_name_configurations branch from 529d300 to 6d33917 Compare August 30, 2022 08:05
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎲

@katbyte katbyte merged commit b2e95ce into hashicorp:main Sep 2, 2022
katbyte added a commit that referenced this pull request Sep 2, 2022
@github-actions github-actions bot added this to the v3.21.0 milestone Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This functionality has been released in v3.21.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2022
@sinbai sinbai deleted the apimanagement/host_name_configurations branch March 28, 2024 02:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants