-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_automation_software_update_configuration
#17902
Conversation
azurerm_automation_software_update_configuration
azurerm_automation_software_update_configuration
website/docs/r/automation_software_update_configuration.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/automation_software_update_configuration.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/automation_software_update_configuration.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/automation_software_update_configuration.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/automation_software_update_configuration.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/automation_software_update_configuration.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/automation_software_update_configuration.html.markdown
Outdated
Show resolved
Hide resolved
0d61a44
to
b6e6a87
Compare
website/docs/r/automation_software_update_configuration.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/automation_software_update_configuration.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/automation_software_update_configuration.html.markdown
Outdated
Show resolved
Hide resolved
internal/services/automation/automation_software_update_configuration.go
Outdated
Show resolved
Hide resolved
internal/services/automation/automation_software_update_configuration.go
Outdated
Show resolved
Hide resolved
internal/services/automation/automation_software_update_configuration.go
Outdated
Show resolved
Hide resolved
website/docs/r/automation_software_update_configuration.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/automation_software_update_configuration.html.markdown
Outdated
Show resolved
Hide resolved
e299d74
to
0e37d21
Compare
internal/services/automation/automation_software_update_configuration.go
Outdated
Show resolved
Hide resolved
internal/services/automation/automation_software_update_configuration.go
Show resolved
Hide resolved
internal/services/automation/automation_software_update_configuration.go
Outdated
Show resolved
Hide resolved
internal/services/automation/automation_software_update_configuration.go
Outdated
Show resolved
Hide resolved
internal/services/automation/automation_software_update_configuration.go
Outdated
Show resolved
Hide resolved
internal/services/automation/automation_software_update_configuration.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some test failures:
------- Stdout: -------
=== RUN TestAccSoftwareUpdateConfiguration_update
=== PAUSE TestAccSoftwareUpdateConfiguration_update
=== CONT TestAccSoftwareUpdateConfiguration_update
testcase.go:110: Step 1/4 error: Error running apply: exit status 1
Error: creating Software Update Configuration: (Name "acctest-suc-220908181914774434" / Automation Account Name "acctest-220908181914774434" / Resource Group "acctestRG-auto-220908181914774434"): automation.SoftwareUpdateConfigurationsClient#Create: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="Error - chosen Azure Automation does not have a Log Analytics workspace linked for operation to succeed. To know which regions are supported for linking, see our documentation at: https://aka.ms/Automation-Region-Mapping"
with azurerm_automation_software_update_configuration.test,
on terraform_plugin_test.tf line 42, in resource "azurerm_automation_software_update_configuration" "test":
42: resource "azurerm_automation_software_update_configuration" "test" {
creating Software Update Configuration: (Name
"acctest-suc-220908181914774434" / Automation Account Name
"acctest-220908181914774434" / Resource Group
"acctestRG-auto-220908181914774434"):
automation.SoftwareUpdateConfigurationsClient#Create: Failure responding to
request: StatusCode=400 -- Original Error: autorest/azure: Service returned
an error. Status=400 Code="BadRequest" Message="Error - chosen Azure
Automation does not have a Log Analytics workspace linked for operation to
succeed. To know which regions are supported for linking, see our
documentation at: https://aka.ms/Automation-Region-Mapping"
--- FAIL: TestAccSoftwareUpdateConfiguration_update (123.43s)
FAIL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a flakey test here:
Error: creating Software Update Configuration: (Name "acctest-suc-220913160651661230" / Automation Account Name "acctest-220913160651661230" / Resource Group "acctestRG-auto-220913160651661230"): automation.SoftwareUpdateConfigurationsClient#Create: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="Error - chosen Azure Automation does not have a Log Analytics workspace linked for operation to succeed. To know which regions are supported for linking, see our documentation at: https://aka.ms/Automation-Region-Mapping"
this might be eventually consistancy issue with LA?
The newest commit id is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have test failures:
------- Stdout: -------
=== RUN TestAccSoftwareUpdateConfiguration_update
=== PAUSE TestAccSoftwareUpdateConfiguration_update
=== CONT TestAccSoftwareUpdateConfiguration_update
testcase.go:110: Step 1/4 error: Error running apply: exit status 1
Error: creating Software Update Configuration: (Name "acctest-suc-220920161519073441" / Automation Account Name "acctest-220920161519073441" / Resource Group "acctestRG-auto-220920161519073441"): automation.SoftwareUpdateConfigurationsClient#Create: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="Error - chosen Azure Automation does not have a Log Analytics workspace linked for operation to succeed. To know which regions are supported for linking, see our documentation at: https://aka.ms/Automation-Region-Mapping"
with azurerm_automation_software_update_configuration.test,
on terraform_plugin_test.tf line 36, in resource "azurerm_automation_software_update_configuration" "test":
36: resource "azurerm_automation_software_update_configuration" "test" {
creating Software Update Configuration: (Name
"acctest-suc-220920161519073441" / Automation Account Name
"acctest-220920161519073441" / Resource Group
"acctestRG-auto-220920161519073441"):
automation.SoftwareUpdateConfigurationsClient#Create: Failure responding to
request: StatusCode=400 -- Original Error: autorest/azure: Service returned
an error. Status=400 Code="BadRequest" Message="Error - chosen Azure
Automation does not have a Log Analytics workspace linked for operation to
succeed. To know which regions are supported for linking, see our
documentation at: https://aka.ms/Automation-Region-Mapping"
--- FAIL: TestAccSoftwareUpdateConfiguration_update (98.30s)
FAIL
sorry, it was my mistake. the root cause of test failure is the region map of automation's linked log analytics workspace is mismatched. because TeamCity use https://learn.microsoft.com/en-us/azure/automation/how-to/region-mappings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass now @wuxu92 ! thanks LGTM ⚙️
This functionality has been released in v3.24.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
add support for azurerm_automation_software_update_configuration
--- PASS: TestAccSoftwareUpdateConfiguration_basic (174.92s)
--- PASS: TestAccSoftwareUpdateConfiguration_update (312.09s)
PASS