new resources: azurerm_datadog_monitor_tag_rule azurerm_datadog_monitor_sso_configuration

[vikotha]

The previous merge for datadog monitor plugin: #16131

[vikotha]

@mbfrahry , this the continuation PR of "azurerm_datadog_monitor" with child resources.
Can you help review this.

[magodo]

Thanks for this PR! 👍
I've taken a look through the documentation and naming stuff, left some comments inline. These comments are mainly for the consistency across the provider codebase.

[vikotha]

@magodo have addressed all the comments

[vikotha]

@mbfrahry can we get assignee on this PR.

[magodo]

@vikotha Thank you for the update! I've left some more comments about the documents of these two resources. Once they are resolved, I'll move on reviewing the code.

[tombuildsstuff]

hey @vikotha

Thanks for this PR - I've taken a look through and left a few design comments inline, but ultimately I think this resource wants to be embedded within the DataDog Monitor resource, since there appears to be a 1:1 relationship between these - which means this could become a block within that resource since it's related configuration. WDYT?

Thanks!

[katbyte]

Thanks @vikotha - looks like we have some test failures still:

[vikotha]

Thanks @vikotha - looks like we have some test failures still:

Is this failing locally? I see all checks successful in the pipeline. In my local run as well, everything passed.

[katbyte]

@vikotha - this is in our CI server were we run the tests against our azure test subscription - maybe the sku you are using is not available/something needs to be done to enableit?

[vikotha]

@vikotha - this is in our CI server were we run the tests against our azure test subscription - maybe the sku you are using is not available/something needs to be done to enableit?

@katbyte, can you check now?
Updated the locations available for datadog

[katbyte]

still failing 😞

------- Stdout: -------
=== RUN   TestAccDatadogMonitorSSO_update
=== PAUSE TestAccDatadogMonitorSSO_update
=== CONT  TestAccDatadogMonitorSSO_update
    testcase.go:110: Step 1/6 error: Error running apply: exit status 1
        
        Error: creating Datadog Monitor: (Monitor Name "acctest-datadog-70" / Resource Group "acctest-datadog-221026161505769070"): datadog.MonitorsClient#Create: Failure sending request: StatusCode=400 -- Original Error: Code="BadRequest" Message="Invalid sku specified"
        
          with azurerm_datadog_monitor.test,
          on terraform_plugin_test.tf line 11, in resource "azurerm_datadog_monitor" "test":
          11: resource "azurerm_datadog_monitor" "test" {
        
--- FAIL: TestAccDatadogMonitorSSO_update (132.35s)
FAIL

[vikotha]

still failing 😞

------- Stdout: -------
=== RUN   TestAccDatadogMonitorSSO_update
=== PAUSE TestAccDatadogMonitorSSO_update
=== CONT  TestAccDatadogMonitorSSO_update
    testcase.go:110: Step 1/6 error: Error running apply: exit status 1
        
        Error: creating Datadog Monitor: (Monitor Name "acctest-datadog-70" / Resource Group "acctest-datadog-221026161505769070"): datadog.MonitorsClient#Create: Failure sending request: StatusCode=400 -- Original Error: Code="BadRequest" Message="Invalid sku specified"
        
          with azurerm_datadog_monitor.test,
          on terraform_plugin_test.tf line 11, in resource "azurerm_datadog_monitor" "test":
          11: resource "azurerm_datadog_monitor" "test" {
        
--- FAIL: TestAccDatadogMonitorSSO_update (132.35s)
FAIL

@katbyte , this should work now. If the env variables are not defined the above error is expected.

[katbyte]

Thanks @vikotha ! LGTM now 🌵

[github-actions]

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.