Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eventhub name validation to include underscores #1768

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Aug 15, 2018

fixes #1767

@katbyte katbyte added this to the 1.13.0 milestone Aug 15, 2018
@katbyte katbyte requested a review from a team August 15, 2018 04:41
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

EventHub tests pass:

screenshot 2018-08-15 at 13 55 46

@tombuildsstuff tombuildsstuff merged commit 85eff5b into master Aug 15, 2018
@tombuildsstuff tombuildsstuff deleted the b-eventhub_name_fix branch August 15, 2018 11:58
tombuildsstuff added a commit that referenced this pull request Aug 15, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Hub name does not allow underscores
2 participants