Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_container_group - Add supports of http_headers #17519

Merged
merged 2 commits into from
Jul 11, 2022
Merged

azurerm_container_group - Add supports of http_headers #17519

merged 2 commits into from
Jul 11, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jul 6, 2022

azurerm_container_group - Add supports of http_headers.

Test

💤  TF_ACC=1 go test -v -timeout=20h ./internal/services/containers -run='TestAccContainerGroup_ProbeHttpGet'
=== RUN   TestAccContainerGroup_ProbeHttpGet
=== PAUSE TestAccContainerGroup_ProbeHttpGet
=== CONT  TestAccContainerGroup_ProbeHttpGet
--- PASS: TestAccContainerGroup_ProbeHttpGet (172.33s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers    172.342s

katbyte
katbyte requested changes Jul 8, 2022
View reviewed changes
internal/services/containers/container_group_resource.go Outdated
}
headers = append(headers, header)
}
sort.Slice(headers, func(i, j int) bool {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come we are sorting these? and could we leave a comment explaining it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original itent there is to make the expand consistent on ordering. Whilst it actually makes less sense but more confusion. So I just removed this.

katbyte
katbyte approved these changes Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@katbyte katbyte merged commit 325603f into hashicorp:main Jul 11, 2022
katbyte added a commit that referenced this pull request Jul 11, 2022
@katbyte
CHANGELOG #17519
9bb0f16
@github-actions github-actions bot added this to the v3.14.0 milestone Jul 11, 2022
@github-actions
Copy link

This functionality has been released in v3.14.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/container-group size/M
Projects
None yet
Milestone
v3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@magodo @katbyte