Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_application_insights_workbook #17368

Merged
merged 16 commits into from
Jul 20, 2022
Merged

New Resource: azurerm_application_insights_workbook #17368

merged 16 commits into from
Jul 20, 2022

Conversation

ms-zhenhua
Copy link
Contributor

@ms-zhenhua ms-zhenhua commented Jun 24, 2022 •
edited
Loading

@ms-zhenhua ms-zhenhua mentioned this pull request Jun 25, 2022
Merged
@ms-zhenhua ms-zhenhua mentioned this pull request Jun 28, 2022
Closed
@katbyte
Copy link
Collaborator

katbyte commented Jul 13, 2022

two test failures
image

@ms-zhenhua
Copy link
Contributor Author

Hi @katbyte, thank you for your reminding. I have successfully re-run all testcases and update the screenshot.

katbyte
katbyte requested changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last comment and this should be good to merge

internal/services/applicationinsights/application_insights_workbook_resource.go Outdated Show resolved Hide resolved
internal/services/applicationinsights/application_insights_workbook_resource.go Outdated Show resolved Hide resolved
@ms-zhenhua
Copy link
Contributor Author

Hi @katbyte, thank you for reviewing the code. It has been updated. Kindly help review it again.

@ms-zhenhua ms-zhenhua requested a review from katbyte July 15, 2022 00:42
@websolut
Copy link

@katbyte do we have an ETA on this PR? I am blocked by inability to create a workbook natively rather than using ARM. Thanks.

katbyte
katbyte approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-zhenhua - LGTM 🦀

@katbyte katbyte merged commit 0ad8c6c into hashicorp:main Jul 20, 2022
katbyte added a commit that referenced this pull request Jul 20, 2022
@katbyte
CHANGELOG #17368
ee9643f
@github-actions github-actions bot added this to the v3.15.0 milestone Jul 20, 2022
@github-actions
Copy link

This functionality has been released in v3.15.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
dependencies documentation service/application-insights size/XL
Projects
None yet
Milestone
v3.15.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Add Azure Monitor Workbooks
4 participants
@ms-zhenhua @katbyte @websolut @tombuildsstuff