Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux_web_app azurerm_linux_web_app_slot expose virtual_network_subnet_id for vNet integration #17354

Merged
merged 22 commits into from
Jun 28, 2022

Conversation

bubbletroubles
Copy link
Contributor

Fixes #15213 for the azurerm_linux_web_app resource.

@bubbletroubles
Copy link
Contributor Author

Tests for azurerm_linux_web_app are passing

TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccLinuxWebApp_ -timeout 500m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccLinuxWebApp_basic
=== PAUSE TestAccLinuxWebApp_basic
=== RUN   TestAccLinuxWebApp_complete
=== PAUSE TestAccLinuxWebApp_complete
=== RUN   TestAccLinuxWebApp_completeUpdated
=== PAUSE TestAccLinuxWebApp_completeUpdated
=== RUN   TestAccLinuxWebApp_backup
=== PAUSE TestAccLinuxWebApp_backup
=== RUN   TestAccLinuxWebApp_backupUpdate
=== PAUSE TestAccLinuxWebApp_backupUpdate
=== RUN   TestAccLinuxWebApp_withConnectionStrings
=== PAUSE TestAccLinuxWebApp_withConnectionStrings
=== RUN   TestAccLinuxWebApp_withConnectionStringsUpdate
=== PAUSE TestAccLinuxWebApp_withConnectionStringsUpdate
=== RUN   TestAccLinuxWebApp_withLogging
=== PAUSE TestAccLinuxWebApp_withLogging
=== RUN   TestAccLinuxWebApp_removeLogging
=== PAUSE TestAccLinuxWebApp_removeLogging
=== RUN   TestAccLinuxWebApp_withLoggingUpdate
=== PAUSE TestAccLinuxWebApp_withLoggingUpdate
=== RUN   TestAccLinuxWebApp_requiresImport
=== PAUSE TestAccLinuxWebApp_requiresImport
=== RUN   TestAccLinuxWebApp_updateServicePlan
=== PAUSE TestAccLinuxWebApp_updateServicePlan
=== RUN   TestAccLinuxWebApp_loadBalancing
=== PAUSE TestAccLinuxWebApp_loadBalancing
=== RUN   TestAccLinuxWebApp_withIPRestrictions
=== PAUSE TestAccLinuxWebApp_withIPRestrictions
=== RUN   TestAccLinuxWebApp_withIPRestrictionsUpdate
=== PAUSE TestAccLinuxWebApp_withIPRestrictionsUpdate
=== RUN   TestAccLinuxWebApp_withAuthSettings
=== PAUSE TestAccLinuxWebApp_withAuthSettings
=== RUN   TestAccLinuxWebApp_withAuthSettingsUpdate
=== PAUSE TestAccLinuxWebApp_withAuthSettingsUpdate
=== RUN   TestAccLinuxWebApp_withStorageAccount
=== PAUSE TestAccLinuxWebApp_withStorageAccount
=== RUN   TestAccLinuxWebApp_withStorageAccountUpdate
=== PAUSE TestAccLinuxWebApp_withStorageAccountUpdate
=== RUN   TestAccLinuxWebApp_identity
=== PAUSE TestAccLinuxWebApp_identity
=== RUN   TestAccLinuxWebApp_identityKeyVaultIdentity
=== PAUSE TestAccLinuxWebApp_identityKeyVaultIdentity
=== RUN   TestAccLinuxWebApp_withDotNet31
=== PAUSE TestAccLinuxWebApp_withDotNet31
=== RUN   TestAccLinuxWebApp_withDotNet50
=== PAUSE TestAccLinuxWebApp_withDotNet50
=== RUN   TestAccLinuxWebApp_withDotNet60
=== PAUSE TestAccLinuxWebApp_withDotNet60
=== RUN   TestAccLinuxWebApp_withPhp74
=== PAUSE TestAccLinuxWebApp_withPhp74
=== RUN   TestAccLinuxWebApp_withPhp80
=== PAUSE TestAccLinuxWebApp_withPhp80
=== RUN   TestAccLinuxWebApp_withPython37
=== PAUSE TestAccLinuxWebApp_withPython37
=== RUN   TestAccLinuxWebApp_withPython38
=== PAUSE TestAccLinuxWebApp_withPython38
=== RUN   TestAccLinuxWebApp_withPython39
=== PAUSE TestAccLinuxWebApp_withPython39
=== RUN   TestAccLinuxWebApp_withRuby26
=== PAUSE TestAccLinuxWebApp_withRuby26
=== RUN   TestAccLinuxWebApp_withRuby27
=== PAUSE TestAccLinuxWebApp_withRuby27
=== RUN   TestAccLinuxWebApp_withNode12LTS
=== PAUSE TestAccLinuxWebApp_withNode12LTS
=== RUN   TestAccLinuxWebApp_withNode14LTS
=== PAUSE TestAccLinuxWebApp_withNode14LTS
=== RUN   TestAccLinuxWebApp_withJre8Java
=== PAUSE TestAccLinuxWebApp_withJre8Java
=== RUN   TestAccLinuxWebApp_withJre11Java
=== PAUSE TestAccLinuxWebApp_withJre11Java
=== RUN   TestAccLinuxWebApp_withJava1109
=== PAUSE TestAccLinuxWebApp_withJava1109
=== RUN   TestAccLinuxWebApp_withJava8u242
=== PAUSE TestAccLinuxWebApp_withJava8u242
=== RUN   TestAccLinuxWebApp_withJava11Tomcat9
=== PAUSE TestAccLinuxWebApp_withJava11Tomcat9
=== RUN   TestAccLinuxWebApp_withJava11Tomcat9041
=== PAUSE TestAccLinuxWebApp_withJava11Tomcat9041
=== RUN   TestAccLinuxWebApp_withJava11Tomcat85
=== PAUSE TestAccLinuxWebApp_withJava11Tomcat85
=== RUN   TestAccLinuxWebApp_withJava11Tomcat8561
=== PAUSE TestAccLinuxWebApp_withJava11Tomcat8561
=== RUN   TestAccLinuxWebApp_withJava8JBOSSEAP73
=== PAUSE TestAccLinuxWebApp_withJava8JBOSSEAP73
=== RUN   TestAccLinuxWebApp_withDocker
=== PAUSE TestAccLinuxWebApp_withDocker
=== RUN   TestAccLinuxWebApp_updateAppStack
=== PAUSE TestAccLinuxWebApp_updateAppStack
=== RUN   TestAccLinuxWebApp_withAutoHealRules
=== PAUSE TestAccLinuxWebApp_withAutoHealRules
=== RUN   TestAccLinuxWebApp_withAutoHealRulesUpdate
=== PAUSE TestAccLinuxWebApp_withAutoHealRulesUpdate
=== RUN   TestAccLinuxWebApp_withAutoHealRulesStatusCodeRange
=== PAUSE TestAccLinuxWebApp_withAutoHealRulesStatusCodeRange
=== RUN   TestAccLinuxWebApp_appSettings
=== PAUSE TestAccLinuxWebApp_appSettings
=== RUN   TestAccLinuxWebApp_stickySettings
=== PAUSE TestAccLinuxWebApp_stickySettings
=== RUN   TestAccLinuxWebApp_stickySettingsUpdate
=== PAUSE TestAccLinuxWebApp_stickySettingsUpdate
=== RUN   TestAccLinuxWebApp_zipDeploy
=== PAUSE TestAccLinuxWebApp_zipDeploy
=== RUN   TestAccLinuxWebApp_vNetIntegration
=== PAUSE TestAccLinuxWebApp_vNetIntegration
=== RUN   TestAccLinuxWebApp_vNetIntegrationUpdate
=== PAUSE TestAccLinuxWebApp_vNetIntegrationUpdate
=== CONT  TestAccLinuxWebApp_basic
=== CONT  TestAccLinuxWebApp_withPython38
=== CONT  TestAccLinuxWebApp_withIPRestrictionsUpdate
=== CONT  TestAccLinuxWebApp_withIPRestrictions
=== CONT  TestAccLinuxWebApp_vNetIntegrationUpdate
--- PASS: TestAccLinuxWebApp_basic (351.81s)
--- PASS: TestAccLinuxWebApp_withPython38 (354.35s)
=== CONT  TestAccLinuxWebApp_vNetIntegration
--- PASS: TestAccLinuxWebApp_withIPRestrictions (354.46s)
=== CONT  TestAccLinuxWebApp_zipDeploy
--- PASS: TestAccLinuxWebApp_withIPRestrictionsUpdate (532.80s)
=== CONT  TestAccLinuxWebApp_stickySettingsUpdate
--- PASS: TestAccLinuxWebApp_zipDeploy (267.03s)
=== CONT  TestAccLinuxWebApp_stickySettings
--- PASS: TestAccLinuxWebApp_vNetIntegration (287.90s)
=== CONT  TestAccLinuxWebApp_appSettings
--- PASS: TestAccLinuxWebApp_stickySettings (182.94s)
=== CONT  TestAccLinuxWebApp_withAutoHealRulesStatusCodeRange
--- PASS: TestAccLinuxWebApp_appSettings (185.17s)
=== CONT  TestAccLinuxWebApp_withAutoHealRulesUpdate
--- PASS: TestAccLinuxWebApp_vNetIntegrationUpdate (535.90s)
=== CONT  TestAccLinuxWebApp_withAutoHealRules
--- PASS: TestAccLinuxWebApp_withAutoHealRulesStatusCodeRange (178.88s)
=== CONT  TestAccLinuxWebApp_updateAppStack
--- PASS: TestAccLinuxWebApp_stickySettingsUpdate (568.49s)
=== CONT  TestAccLinuxWebApp_withDocker
--- PASS: TestAccLinuxWebApp_withAutoHealRules (238.99s)
=== CONT  TestAccLinuxWebApp_withJava8JBOSSEAP73
--- PASS: TestAccLinuxWebApp_updateAppStack (310.74s)
=== CONT  TestAccLinuxWebApp_withJava11Tomcat8561
--- PASS: TestAccLinuxWebApp_withJava8JBOSSEAP73 (177.04s)
=== CONT  TestAccLinuxWebApp_withJava11Tomcat85
--- PASS: TestAccLinuxWebApp_withAutoHealRulesUpdate (496.11s)
=== CONT  TestAccLinuxWebApp_withJava11Tomcat9041
--- PASS: TestAccLinuxWebApp_withDocker (242.43s)
=== CONT  TestAccLinuxWebApp_withJava11Tomcat9
--- PASS: TestAccLinuxWebApp_withJava11Tomcat8561 (168.58s)
=== CONT  TestAccLinuxWebApp_withJava8u242
--- PASS: TestAccLinuxWebApp_withJava11Tomcat85 (170.48s)
=== CONT  TestAccLinuxWebApp_withJava1109
--- PASS: TestAccLinuxWebApp_withJava11Tomcat9041 (171.24s)
=== CONT  TestAccLinuxWebApp_withJre11Java
--- PASS: TestAccLinuxWebApp_withJava11Tomcat9 (178.41s)
=== CONT  TestAccLinuxWebApp_withJre8Java
--- PASS: TestAccLinuxWebApp_withJava8u242 (198.96s)
=== CONT  TestAccLinuxWebApp_withNode14LTS
--- PASS: TestAccLinuxWebApp_withJava1109 (201.20s)
=== CONT  TestAccLinuxWebApp_withNode12LTS
--- PASS: TestAccLinuxWebApp_withJre11Java (216.83s)
=== CONT  TestAccLinuxWebApp_withRuby27
--- PASS: TestAccLinuxWebApp_withJre8Java (215.93s)
=== CONT  TestAccLinuxWebApp_withRuby26
--- PASS: TestAccLinuxWebApp_withNode14LTS (184.47s)
=== CONT  TestAccLinuxWebApp_withPython39
--- PASS: TestAccLinuxWebApp_withNode12LTS (193.32s)
=== CONT  TestAccLinuxWebApp_loadBalancing
--- PASS: TestAccLinuxWebApp_withRuby27 (190.12s)
=== CONT  TestAccLinuxWebApp_updateServicePlan
--- PASS: TestAccLinuxWebApp_withRuby26 (187.97s)
=== CONT  TestAccLinuxWebApp_requiresImport
--- PASS: TestAccLinuxWebApp_withPython39 (177.19s)
=== CONT  TestAccLinuxWebApp_withLoggingUpdate
--- PASS: TestAccLinuxWebApp_loadBalancing (171.35s)
=== CONT  TestAccLinuxWebApp_removeLogging
--- PASS: TestAccLinuxWebApp_requiresImport (188.75s)
=== CONT  TestAccLinuxWebApp_withLogging
--- PASS: TestAccLinuxWebApp_updateServicePlan (284.42s)
=== CONT  TestAccLinuxWebApp_withConnectionStringsUpdate
--- PASS: TestAccLinuxWebApp_withLogging (203.43s)
=== CONT  TestAccLinuxWebApp_withConnectionStrings
--- PASS: TestAccLinuxWebApp_removeLogging (299.83s)
=== CONT  TestAccLinuxWebApp_backupUpdate
--- PASS: TestAccLinuxWebApp_withConnectionStrings (180.19s)
=== CONT  TestAccLinuxWebApp_backup
--- PASS: TestAccLinuxWebApp_withLoggingUpdate (718.41s)
=== CONT  TestAccLinuxWebApp_completeUpdated
--- PASS: TestAccLinuxWebApp_backup (344.08s)
=== CONT  TestAccLinuxWebApp_complete
--- PASS: TestAccLinuxWebApp_backupUpdate (535.24s)
=== CONT  TestAccLinuxWebApp_withDotNet31
--- PASS: TestAccLinuxWebApp_withConnectionStringsUpdate (759.78s)
=== CONT  TestAccLinuxWebApp_withPython37
--- PASS: TestAccLinuxWebApp_withDotNet31 (237.73s)
=== CONT  TestAccLinuxWebApp_withPhp80
--- PASS: TestAccLinuxWebApp_complete (273.89s)
=== CONT  TestAccLinuxWebApp_withPhp74
--- PASS: TestAccLinuxWebApp_withPython37 (212.54s)
=== CONT  TestAccLinuxWebApp_withDotNet60
--- PASS: TestAccLinuxWebApp_withPhp74 (179.16s)
=== CONT  TestAccLinuxWebApp_withDotNet50
--- PASS: TestAccLinuxWebApp_withPhp80 (188.79s)
=== CONT  TestAccLinuxWebApp_withStorageAccountUpdate
--- PASS: TestAccLinuxWebApp_completeUpdated (582.83s)
=== CONT  TestAccLinuxWebApp_identityKeyVaultIdentity
--- PASS: TestAccLinuxWebApp_withDotNet60 (196.71s)
=== CONT  TestAccLinuxWebApp_identity
--- PASS: TestAccLinuxWebApp_withDotNet50 (196.65s)
=== CONT  TestAccLinuxWebApp_withAuthSettingsUpdate
--- PASS: TestAccLinuxWebApp_identityKeyVaultIdentity (301.12s)
=== CONT  TestAccLinuxWebApp_withStorageAccount
--- PASS: TestAccLinuxWebApp_withStorageAccount (242.37s)
=== CONT  TestAccLinuxWebApp_withAuthSettings
--- PASS: TestAccLinuxWebApp_withStorageAccountUpdate (623.81s)
--- PASS: TestAccLinuxWebApp_identity (598.70s)
--- PASS: TestAccLinuxWebApp_withAuthSettings (182.55s)
--- PASS: TestAccLinuxWebApp_withAuthSettingsUpdate (603.17s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    4100.654s

@bubbletroubles
Copy link
Contributor Author

Tests for azurerm_linux_web_app_slot are passing

$ make acctests SERVICE='appservice' TESTARGS='-run=TestAccLinuxWebAppSlot_' TESTTIMEOUT='500m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccLinuxWebAppSlot_ -timeout 500m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccLinuxWebAppSlot_basic
=== PAUSE TestAccLinuxWebAppSlot_basic
=== RUN   TestAccLinuxWebAppSlot_requiresImport
=== PAUSE TestAccLinuxWebAppSlot_requiresImport
=== RUN   TestAccLinuxWebAppSlot_autoSwap
=== PAUSE TestAccLinuxWebAppSlot_autoSwap
=== RUN   TestAccLinuxWebAppSlot_complete
=== PAUSE TestAccLinuxWebAppSlot_complete
=== RUN   TestAccLinuxWebAppSlot_completeUpdate
=== PAUSE TestAccLinuxWebAppSlot_completeUpdate
=== RUN   TestAccLinuxWebAppSlot_backup
=== PAUSE TestAccLinuxWebAppSlot_backup
=== RUN   TestAccLinuxWebAppSlot_backupUpdate
=== PAUSE TestAccLinuxWebAppSlot_backupUpdate
=== RUN   TestAccLinuxWebAppSlot_scmIpRestrictionSubnet
=== PAUSE TestAccLinuxWebAppSlot_scmIpRestrictionSubnet
=== RUN   TestAccLinuxWebAppSlot_scmIpRestrictionHeaders
=== PAUSE TestAccLinuxWebAppSlot_scmIpRestrictionHeaders
=== RUN   TestAccLinuxWebAppSlot_withConnectionStrings
=== PAUSE TestAccLinuxWebAppSlot_withConnectionStrings
=== RUN   TestAccLinuxWebAppSlot_withConnectionStringsUpdate
=== PAUSE TestAccLinuxWebAppSlot_withConnectionStringsUpdate
=== RUN   TestAccLinuxWebAppSlot_withIPRestrictions
=== PAUSE TestAccLinuxWebAppSlot_withIPRestrictions
=== RUN   TestAccLinuxWebAppSlot_withIPRestrictionsUpdate
=== PAUSE TestAccLinuxWebAppSlot_withIPRestrictionsUpdate
=== RUN   TestAccLinuxWebAppSlot_withAuthSettings
=== PAUSE TestAccLinuxWebAppSlot_withAuthSettings
=== RUN   TestAccLinuxWebAppSlot_withAuthSettingsUpdate
=== PAUSE TestAccLinuxWebAppSlot_withAuthSettingsUpdate
=== RUN   TestAccLinuxWebAppSlot_withAutoHealRules
=== PAUSE TestAccLinuxWebAppSlot_withAutoHealRules
=== RUN   TestAccLinuxWebAppSlot_withAutoHealRulesUpdate
=== PAUSE TestAccLinuxWebAppSlot_withAutoHealRulesUpdate
=== RUN   TestAccLinuxWebAppSlot_appSettings
=== PAUSE TestAccLinuxWebAppSlot_appSettings
=== RUN   TestAccLinuxWebAppSlot_identity
=== PAUSE TestAccLinuxWebAppSlot_identity
=== RUN   TestAccLinuxWebAppSlot_identityKeyVaultIdentity
=== PAUSE TestAccLinuxWebAppSlot_identityKeyVaultIdentity
=== RUN   TestAccLinuxWebAppSlot_loadBalancing
=== PAUSE TestAccLinuxWebAppSlot_loadBalancing
=== RUN   TestAccLinuxWebAppSlot_detailedLogging
=== PAUSE TestAccLinuxWebAppSlot_detailedLogging
=== RUN   TestAccLinuxWebAppSlot_withLoggingUpdate
=== PAUSE TestAccLinuxWebAppSlot_withLoggingUpdate
=== RUN   TestAccLinuxWebAppSlot_withDotNet31
=== PAUSE TestAccLinuxWebAppSlot_withDotNet31
=== RUN   TestAccLinuxWebAppSlot_withDotNet50
=== PAUSE TestAccLinuxWebAppSlot_withDotNet50
=== RUN   TestAccLinuxWebAppSlot_withDotNet60
=== PAUSE TestAccLinuxWebAppSlot_withDotNet60
=== RUN   TestAccLinuxWebAppSlot_withPhp74
=== PAUSE TestAccLinuxWebAppSlot_withPhp74
=== RUN   TestAccLinuxWebAppSlot_withPhp80
=== PAUSE TestAccLinuxWebAppSlot_withPhp80
=== RUN   TestAccLinuxWebAppSlot_withPython37
=== PAUSE TestAccLinuxWebAppSlot_withPython37
=== RUN   TestAccLinuxWebAppSlot_withPython38
=== PAUSE TestAccLinuxWebAppSlot_withPython38
=== RUN   TestAccLinuxWebAppSlot_withPython39
=== PAUSE TestAccLinuxWebAppSlot_withPython39
=== RUN   TestAccLinuxWebAppSlot_withRuby26
=== PAUSE TestAccLinuxWebAppSlot_withRuby26
=== RUN   TestAccLinuxWebAppSlot_withRuby27
=== PAUSE TestAccLinuxWebAppSlot_withRuby27
=== RUN   TestAccLinuxWebAppSlot_withNode12LTS
=== PAUSE TestAccLinuxWebAppSlot_withNode12LTS
=== RUN   TestAccLinuxWebAppSlot_withNode14LTS
=== PAUSE TestAccLinuxWebAppSlot_withNode14LTS
=== RUN   TestAccLinuxWebAppSlot_withNode16LTS
=== PAUSE TestAccLinuxWebAppSlot_withNode16LTS
=== RUN   TestAccLinuxWebAppSlot_withJre8Java
=== PAUSE TestAccLinuxWebAppSlot_withJre8Java
=== RUN   TestAccLinuxWebAppSlot_withJre11Java
=== PAUSE TestAccLinuxWebAppSlot_withJre11Java
=== RUN   TestAccLinuxWebAppSlot_withJava1109
=== PAUSE TestAccLinuxWebAppSlot_withJava1109
=== RUN   TestAccLinuxWebAppSlot_withJava8u242
=== PAUSE TestAccLinuxWebAppSlot_withJava8u242
=== RUN   TestAccLinuxWebAppSlot_withJava11Tomcat9
=== PAUSE TestAccLinuxWebAppSlot_withJava11Tomcat9
=== RUN   TestAccLinuxWebAppSlot_withJava11Tomcat8561
=== PAUSE TestAccLinuxWebAppSlot_withJava11Tomcat8561
=== RUN   TestAccLinuxWebAppSlot_withJava8JBOSSEAP73
=== PAUSE TestAccLinuxWebAppSlot_withJava8JBOSSEAP73
=== RUN   TestAccLinuxWebAppSlot_withDocker
=== PAUSE TestAccLinuxWebAppSlot_withDocker
=== RUN   TestAccLinuxWebAppSlot_zipDeploy
=== PAUSE TestAccLinuxWebAppSlot_zipDeploy
=== RUN   TestAccLinuxWebAppSlot_vNetIntegration
=== PAUSE TestAccLinuxWebAppSlot_vNetIntegration
=== RUN   TestAccLinuxWebAppSlot_vNetIntegrationUpdate
=== PAUSE TestAccLinuxWebAppSlot_vNetIntegrationUpdate
=== CONT  TestAccLinuxWebAppSlot_withJava8u242
=== CONT  TestAccLinuxWebAppSlot_basic
=== CONT  TestAccLinuxWebAppSlot_withJava1109
=== CONT  TestAccLinuxWebAppSlot_withJre11Java
=== CONT  TestAccLinuxWebAppSlot_withJre8Java
--- PASS: TestAccLinuxWebAppSlot_withJava1109 (292.75s)
--- PASS: TestAccLinuxWebAppSlot_basic (339.82s)
=== CONT  TestAccLinuxWebAppSlot_withNode16LTS
--- PASS: TestAccLinuxWebAppSlot_withJava8u242 (341.54s)
=== CONT  TestAccLinuxWebAppSlot_withNode14LTS
=== CONT  TestAccLinuxWebAppSlot_withNode12LTS
--- PASS: TestAccLinuxWebAppSlot_withJre11Java (358.73s)
=== CONT  TestAccLinuxWebAppSlot_withRuby27
--- PASS: TestAccLinuxWebAppSlot_withJre8Java (297.22s)
--- PASS: TestAccLinuxWebAppSlot_withNode16LTS (259.67s)
=== CONT  TestAccLinuxWebAppSlot_withRuby26
--- PASS: TestAccLinuxWebAppSlot_withNode12LTS (255.90s)
=== CONT  TestAccLinuxWebAppSlot_withPython39
--- PASS: TestAccLinuxWebAppSlot_withNode14LTS (308.90s)
=== CONT  TestAccLinuxWebAppSlot_withPython38
--- PASS: TestAccLinuxWebAppSlot_withRuby26 (231.12s)
=== CONT  TestAccLinuxWebAppSlot_withPython37
--- PASS: TestAccLinuxWebAppSlot_withRuby27 (284.12s)
=== CONT  TestAccLinuxWebAppSlot_withPhp80
--- PASS: TestAccLinuxWebAppSlot_withPython38 (243.86s)
=== CONT  TestAccLinuxWebAppSlot_withPhp74
--- PASS: TestAccLinuxWebAppSlot_withPython39 (291.03s)
=== CONT  TestAccLinuxWebAppSlot_withDotNet60
--- PASS: TestAccLinuxWebAppSlot_withPython37 (218.38s)
=== CONT  TestAccLinuxWebAppSlot_withDotNet50
--- PASS: TestAccLinuxWebAppSlot_withPhp80 (218.42s)
=== CONT  TestAccLinuxWebAppSlot_withDotNet31
--- PASS: TestAccLinuxWebAppSlot_withPhp74 (231.81s)
=== CONT  TestAccLinuxWebAppSlot_withLoggingUpdate
--- PASS: TestAccLinuxWebAppSlot_withDotNet60 (223.59s)
=== CONT  TestAccLinuxWebAppSlot_detailedLogging
--- PASS: TestAccLinuxWebAppSlot_withDotNet50 (227.72s)
=== CONT  TestAccLinuxWebAppSlot_loadBalancing
--- PASS: TestAccLinuxWebAppSlot_withDotNet31 (295.10s)
=== CONT  TestAccLinuxWebAppSlot_identityKeyVaultIdentity
--- PASS: TestAccLinuxWebAppSlot_detailedLogging (260.22s)
=== CONT  TestAccLinuxWebAppSlot_identity
--- PASS: TestAccLinuxWebAppSlot_loadBalancing (333.36s)
=== CONT  TestAccLinuxWebAppSlot_appSettings
--- PASS: TestAccLinuxWebAppSlot_identityKeyVaultIdentity (395.25s)
=== CONT  TestAccLinuxWebAppSlot_withAutoHealRulesUpdate
--- PASS: TestAccLinuxWebAppSlot_appSettings (294.65s)
=== CONT  TestAccLinuxWebAppSlot_withAutoHealRules
--- PASS: TestAccLinuxWebAppSlot_withLoggingUpdate (895.63s)
=== CONT  TestAccLinuxWebAppSlot_withAuthSettingsUpdate
--- PASS: TestAccLinuxWebAppSlot_identity (711.70s)
=== CONT  TestAccLinuxWebAppSlot_withAuthSettings
--- PASS: TestAccLinuxWebAppSlot_withAutoHealRules (237.68s)
=== CONT  TestAccLinuxWebAppSlot_withIPRestrictionsUpdate
--- PASS: TestAccLinuxWebAppSlot_withAuthSettings (267.89s)
=== CONT  TestAccLinuxWebAppSlot_withIPRestrictions
--- PASS: TestAccLinuxWebAppSlot_withAutoHealRulesUpdate (630.43s)
=== CONT  TestAccLinuxWebAppSlot_withConnectionStringsUpdate
--- PASS: TestAccLinuxWebAppSlot_withIPRestrictions (224.36s)
=== CONT  TestAccLinuxWebAppSlot_withConnectionStrings
--- PASS: TestAccLinuxWebAppSlot_withIPRestrictionsUpdate (474.13s)
=== CONT  TestAccLinuxWebAppSlot_scmIpRestrictionHeaders
--- PASS: TestAccLinuxWebAppSlot_withAuthSettingsUpdate (655.98s)
=== CONT  TestAccLinuxWebAppSlot_scmIpRestrictionSubnet
--- PASS: TestAccLinuxWebAppSlot_withConnectionStrings (247.91s)
=== CONT  TestAccLinuxWebAppSlot_backupUpdate
--- PASS: TestAccLinuxWebAppSlot_scmIpRestrictionHeaders (305.58s)
=== CONT  TestAccLinuxWebAppSlot_backup
--- PASS: TestAccLinuxWebAppSlot_scmIpRestrictionSubnet (277.27s)
=== CONT  TestAccLinuxWebAppSlot_completeUpdate
--- PASS: TestAccLinuxWebAppSlot_withConnectionStringsUpdate (757.33s)
=== CONT  TestAccLinuxWebAppSlot_complete
--- PASS: TestAccLinuxWebAppSlot_backup (317.16s)
=== CONT  TestAccLinuxWebAppSlot_autoSwap
--- PASS: TestAccLinuxWebAppSlot_backupUpdate (504.82s)
=== CONT  TestAccLinuxWebAppSlot_requiresImport
--- PASS: TestAccLinuxWebAppSlot_complete (231.13s)
=== CONT  TestAccLinuxWebAppSlot_withDocker
--- PASS: TestAccLinuxWebAppSlot_completeUpdate (468.34s)
=== CONT  TestAccLinuxWebAppSlot_vNetIntegrationUpdate
--- PASS: TestAccLinuxWebAppSlot_autoSwap (225.50s)
=== CONT  TestAccLinuxWebAppSlot_vNetIntegration
--- PASS: TestAccLinuxWebAppSlot_withDocker (272.19s)
=== CONT  TestAccLinuxWebAppSlot_zipDeploy
--- PASS: TestAccLinuxWebAppSlot_requiresImport (330.13s)
=== CONT  TestAccLinuxWebAppSlot_withJava11Tomcat8561
--- PASS: TestAccLinuxWebAppSlot_vNetIntegration (322.46s)
=== CONT  TestAccLinuxWebAppSlot_withJava8JBOSSEAP73
--- PASS: TestAccLinuxWebAppSlot_withJava11Tomcat8561 (218.75s)
=== CONT  TestAccLinuxWebAppSlot_withJava11Tomcat9
--- PASS: TestAccLinuxWebAppSlot_vNetIntegrationUpdate (492.41s)
--- PASS: TestAccLinuxWebAppSlot_zipDeploy (293.54s)
--- PASS: TestAccLinuxWebAppSlot_withJava8JBOSSEAP73 (220.87s)
--- PASS: TestAccLinuxWebAppSlot_withJava11Tomcat9 (237.38s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    4135.719s

@bubbletroubles
Copy link
Contributor Author

@tombuildsstuff @katbyte @jackofallops @catriona-m @stephybun this one is now ready for review. I couldn't press "Request review" in the PR so if there is a better way let me know.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥫

@bubbletroubles
Copy link
Contributor Author

LGTM 🥫

Thanks @katbyte there were some merge conflicts with the website docs. I've fixed that now. Can you approve again?

@katbyte katbyte changed the title azurerm_linux_web_app expose virtual_network_subnet_id for vNet integration azurerm_linux_web_app azurerm_linux_web_app_slot expose virtual_network_subnet_id for vNet integration Jun 28, 2022
@katbyte katbyte merged commit 2dc88f0 into hashicorp:main Jun 28, 2022
@github-actions github-actions bot added this to the v3.12.0 milestone Jun 28, 2022
katbyte added a commit that referenced this pull request Jun 28, 2022
@bubbletroubles bubbletroubles deleted the patch-1 branch June 29, 2022 00:05
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v3.12.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_app_service_virtual_network_swift_connection - Require permission subnet/write
2 participants