Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r\digital_twins_instance: support identity #17076

Merged
merged 2 commits into from
Jun 27, 2022
Merged

r\digital_twins_instance: support identity #17076

merged 2 commits into from
Jun 27, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Jun 2, 2022

Fix #15970

@myc2h6o myc2h6o mentioned this pull request Jun 2, 2022
Closed
@myc2h6o
Copy link
Contributor Author

myc2h6o commented Jun 2, 2022

Test result
image

tombuildsstuff
tombuildsstuff approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment since the test case can be reused, but this otherwise LGTM 👍

internal/services/digitaltwins/digital_twins_instance_resource_test.go Outdated
`, r.template(data), data.RandomInteger)
}

func (r DigitalTwinsInstanceResource) identityNone(data acceptance.TestData) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use basic for this purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombuildsstuff yes, I've updated the test code to reuse the basic config

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Jun 7, 2022

Updated test result
image

katbyte
katbyte approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌻

@katbyte katbyte merged commit c0ddf4a into hashicorp:main Jun 27, 2022
@github-actions github-actions bot added this to the v3.12.0 milestone Jun 27, 2022
katbyte added a commit that referenced this pull request Jun 27, 2022
@katbyte
CHANGELOG/md for #17076
7deb856
@myc2h6o myc2h6o deleted the digital_twins_identity branch June 28, 2022 03:40
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v3.12.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation service/digital-twins size/M
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging this pull request may close these issues.

Support for identity parameter in azurerm_digital_twins_instance
3 participants
@myc2h6o @tombuildsstuff @katbyte