Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux_virtual_machine azurerm_windows_virtual_machine: Add support for confidential vm #16905

Merged
merged 3 commits into from
May 25, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented May 22, 2022

  • Support Confidential VM, two new properties under os_disk: security_encryption_type to specify the encryption type of the os disk when it's a confidential vm, and secure_vm_disk_encryption_set_id to specify the disk encryption set if CMK is used. Property names are taken from Confidential Compute CLI Change Request - VM / VMSS Create Azure/azure-cli#22199 per service team to keep the user experience consistent.
  • As confidential vm requires vtpm and secure_boot to be enabled, error will be thrown if they are not set to true when security_encryption_type is specified.
  • Similar to TrustedLaunch, value of VirtualMachineProperties.SecurityProfile.SecurityType could be decided and set to ConfidentialVM when security_encryption_type is specified.

@myc2h6o myc2h6o force-pushed the confidential_vm branch from 143cdef to fb1d91f Compare May 22, 2022 07:37
@myc2h6o
Copy link
Contributor Author

myc2h6o commented May 22, 2022

Test result of TestAccLinuxVirtualMachine_|TestAccWindowsVirtualMachine_ (Failed tests fail on main for same reason):
image

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myc2h6o thank you for this PR... LGTM... 🚀

@WodansSon WodansSon changed the title r\linux_virtual_machine r\windows_virtual_machine: Add support for confidential vm azurerm_linux_virtual_machine azurerm_windows_virtual_machine: Add support for confidential vm May 24, 2022
@WodansSon WodansSon merged commit ee30790 into hashicorp:main May 25, 2022
WodansSon added a commit that referenced this pull request May 25, 2022
@myc2h6o myc2h6o deleted the confidential_vm branch May 25, 2022 03:28
@github-actions
Copy link

This functionality has been released in v3.8.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants