Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r\windows_virtual_machine: Add ForceNew to timezone #16866

Merged
merged 1 commit into from
May 23, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented May 19, 2022

Fix #16848

timezone cannot be changed. Error: Code="PropertyChangeNotAllowed" Message="Changing property 'windowsConfiguration.timeZone' is not allowed." Target="windowsConfiguration.timeZone"

Below is the schema on old vm resource. Seems this is forgot on the new resource (only applicable for windows vm).

The Update function doesn't check the timezone, so only need to add the ForceNew

"timezone": {
Type: pluginsdk.TypeString,
Optional: true,
ForceNew: true,

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v3.8.0 milestone May 23, 2022
@mbfrahry mbfrahry merged commit 5cb48c4 into hashicorp:main May 23, 2022
mbfrahry added a commit that referenced this pull request May 23, 2022
@myc2h6o myc2h6o deleted the vm_timezone branch May 24, 2022 01:44
@github-actions
Copy link

This functionality has been released in v3.8.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_windows_virtual_machine and timezone
2 participants