Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TC for azurerm_cosmosdb_cassandra_cluster and azurerm_cosmosdb_cassandra_datacenter #16752

Merged
merged 7 commits into from
May 18, 2022
Merged

Fix TC for azurerm_cosmosdb_cassandra_cluster and azurerm_cosmosdb_cassandra_datacenter #16752

merged 7 commits into from
May 18, 2022

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented May 12, 2022 •
edited
Loading

This PR is to fix TCs of azurerm_cosmosdb_cassandra_cluster and azurerm_cosmosdb_cassandra_datacenter.

--- PASS: TestAccCassandraSequential/cluster (1881.87s)
--- PASS: TestAccCassandraSequential/cluster/basic (928.21s)
--- PASS: TestAccCassandraSequential/cluster/requiresImport (953.66s)
--- PASS: TestAccCassandraSequential/dataCenter (5897.76s)
--- PASS: TestAccCassandraSequential/dataCenter/requiresImport (3145.14s)
--- PASS: TestAccCassandraSequential/dataCenter/basic (2752.63s)

image

@neil-yechenwei neil-yechenwei mentioned this pull request May 12, 2022
Merged
@WodansSon WodansSon added this to the v3.7.0 milestone May 12, 2022
WodansSon
WodansSon approved these changes May 12, 2022
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neil-yechenwei Thank you for this PR... this LGTM! 🚀

katbyte
katbyte approved these changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍾

@katbyte
Copy link
Collaborator

katbyte commented May 13, 2022

@neil-yechenwei - could we fix up the tests here?

neil-yechenwei added 2 commits May 13, 2022 11:23
@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented May 13, 2022 •
edited
Loading

@katbyte , updated this PR. Please take another look. Thanks.

@neil-yechenwei neil-yechenwei requested a review from katbyte May 13, 2022 04:23
@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented May 16, 2022 •
edited
Loading

@katbyte , if you don't mind, could you review/merge this PR asap since I have several PRs depending on this PR? Thanks in advance.

This was referenced May 16, 2022
Merged
Merged
katbyte
katbyte approved these changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks LGTM 🦋

@katbyte katbyte merged commit ba15449 into hashicorp:main May 18, 2022
@github-actions
Copy link

This functionality has been released in v3.7.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WodansSon WodansSon WodansSon approved these changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/cosmosdb size/M
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neil-yechenwei @katbyte @WodansSon