Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_logz_sub_account #16581

Merged
merged 9 commits into from
Jul 6, 2022
Merged

New Resource: azurerm_logz_sub_account #16581

merged 9 commits into from
Jul 6, 2022

Conversation

ms-zhenhua
Copy link
Contributor

@ms-zhenhua ms-zhenhua commented Apr 28, 2022 •
edited
Loading

magodo
magodo requested changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
I've taken a look through and left some comments inline. Besides, I'm wondering whether we can rename the azurerm_logz_sub_account to azurerm_logz_monitor_account to be clear?

internal/services/logz/logz_monitor_resource_test.go Show resolved Hide resolved
internal/services/logz/logz_monitor_resource_test.go Outdated Show resolved Hide resolved
internal/services/logz/logz_sub_account_resource.go Show resolved Hide resolved
internal/services/logz/logz_sub_account_resource.go Outdated Show resolved Hide resolved
internal/services/logz/logz_sub_account_resource.go Outdated Show resolved Hide resolved
internal/services/logz/logz_sub_account_resource_test.go Outdated Show resolved Hide resolved
internal/services/logz/logz_sub_account_resource_test.go Outdated Show resolved Hide resolved
internal/services/logz/logz_sub_account_resource_test.go Outdated Show resolved Hide resolved
internal/services/logz/logz_sub_account_resource_test.go Outdated Show resolved Hide resolved
@ms-zhenhua
Copy link
Contributor Author

Hi @magodo, thank you for reviewing my code. I have updated the code and re-run the test cases. Kindly help review it again.

@ms-zhenhua ms-zhenhua requested a review from magodo May 24, 2022 02:11
WodansSon
WodansSon requested changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ms-zhenhua thank you for this PR as @magodo said, this is very close to being ready, however I have left some minor comments on the PR... thanks a gain for the PR it is looking really good so far! 🚀

internal/services/logz/logz_sub_account_resource.go Show resolved Hide resolved
internal/services/logz/validate/logz_monitor_name.go Outdated Show resolved Hide resolved
website/docs/r/logz_sub_account.html.markdown Outdated Show resolved Hide resolved
website/docs/r/logz_sub_account.html.markdown Outdated Show resolved Hide resolved
website/docs/r/logz_sub_account.html.markdown Outdated Show resolved Hide resolved
website/docs/r/logz_sub_account.html.markdown Outdated Show resolved Hide resolved
website/docs/r/logz_sub_account.html.markdown Outdated Show resolved Hide resolved
website/docs/r/logz_sub_account.html.markdown Outdated Show resolved Hide resolved
@ms-zhenhua
Copy link
Contributor Author

Hi @WodansSon, thank you for reviewing my code. I have updated the code. Kindly help review it again.

@ms-zhenhua ms-zhenhua requested a review from WodansSon May 26, 2022 08:24
tombuildsstuff
tombuildsstuff suggested changes May 31, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ms-zhenhua

Thanks for pushing those changes - I've taken a look through and left some comments inline, but relying on the internal logic of the Azure API means this isn't actually testing the codepath used by end-users - so the tests right now aren't necessarily working. Can we update this to use the regular test name?

Thanks!

internal/services/logz/logz_monitor_resource_test.go Outdated Show resolved Hide resolved
internal/services/logz/logz_monitor_resource_test.go Outdated Show resolved Hide resolved
internal/services/logz/logz_sub_account_resource.go Outdated Show resolved Hide resolved
internal/services/logz/logz_sub_account_resource.go Show resolved Hide resolved
internal/services/logz/logz_sub_account_resource_test.go Outdated Show resolved Hide resolved
internal/services/logz/logz_sub_account_resource_test.go Outdated Show resolved Hide resolved
internal/services/logz/logz_tag_rule_resource_test.go Outdated Show resolved Hide resolved
internal/services/logz/logz_sub_account_resource_test.go Outdated Show resolved Hide resolved
website/docs/r/logz_sub_account.html.markdown Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added waiting-response upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels May 31, 2022
@ms-zhenhua
Copy link
Contributor Author

Hi @tombuildsstuff, thank you for reviewing my code. I have updated the code and re-run all test cases. Kindly help review it again. Thanks.

@ms-zhenhua ms-zhenhua requested a review from tombuildsstuff June 2, 2022 09:44
katbyte
katbyte approved these changes Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💎

@katbyte katbyte merged commit c8a8897 into hashicorp:main Jul 6, 2022
katbyte added a commit that referenced this pull request Jul 6, 2022
@katbyte
CHANGELOG #16581
a36ef56
@github-actions github-actions bot added this to the v3.13.0 milestone Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v3.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@magodo magodo Awaiting requested review from magodo

@WodansSon WodansSon Awaiting requested review from WodansSon

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
documentation service/logz size/XL upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ms-zhenhua @tombuildsstuff @katbyte @magodo @WodansSon