Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic_container_enabled field to the schemas. Fix #16525 #16526

Closed
wants to merge 1 commit into from

Conversation

lonegunmanb
Copy link
Contributor

@lonegunmanb lonegunmanb commented Apr 24, 2022

Fix #16525

Four resources are affected:

  • azurerm_data_factory_dataset_binary
  • azurerm_data_factory_dataset_delimited_text
  • azurerm_data_factory_dataset_json
  • azurerm_data_factory_dataset_parquet

Acc tests:

=== RUN TestAccDataFactoryDatasetDelimitedText_http
=== PAUSE TestAccDataFactoryDatasetDelimitedText_http
=== CONT TestAccDataFactoryDatasetDelimitedText_http
--- PASS: TestAccDataFactoryDatasetDelimitedText_http (242.30s)
=== RUN TestAccDataFactoryDatasetDelimitedText_http_update
=== PAUSE TestAccDataFactoryDatasetDelimitedText_http_update
=== CONT TestAccDataFactoryDatasetDelimitedText_http_update
--- PASS: TestAccDataFactoryDatasetDelimitedText_http_update (353.12s)
=== RUN TestAccDataFactoryDatasetDelimitedText_blob_basic
=== PAUSE TestAccDataFactoryDatasetDelimitedText_blob_basic
=== CONT TestAccDataFactoryDatasetDelimitedText_blob_basic
--- PASS: TestAccDataFactoryDatasetDelimitedText_blob_basic (263.16s)
=== RUN TestAccDataFactoryDatasetDelimitedText_blob
=== PAUSE TestAccDataFactoryDatasetDelimitedText_blob
=== CONT TestAccDataFactoryDatasetDelimitedText_blob
--- PASS: TestAccDataFactoryDatasetDelimitedText_blob (265.85s)
=== RUN TestAccDataFactoryDatasetDelimitedText_blob_empty_path
=== PAUSE TestAccDataFactoryDatasetDelimitedText_blob_empty_path
=== CONT TestAccDataFactoryDatasetDelimitedText_blob_empty_path
--- PASS: TestAccDataFactoryDatasetDelimitedText_blob_empty_path (263.97s)
=== RUN TestAccDataFactoryDatasetDelimitedText_blobFS
=== PAUSE TestAccDataFactoryDatasetDelimitedText_blobFS
=== CONT TestAccDataFactoryDatasetDelimitedText_blobFS
--- PASS: TestAccDataFactoryDatasetDelimitedText_blobFS (245.35s)
PASS

=== RUN TestAccDataFactoryDatasetBinary_blob
=== PAUSE TestAccDataFactoryDatasetBinary_blob
=== CONT TestAccDataFactoryDatasetBinary_blob
--- PASS: TestAccDataFactoryDatasetBinary_blob (192.96s)
=== RUN TestAccDataFactoryDatasetBinary_blob_with_filepath
=== PAUSE TestAccDataFactoryDatasetBinary_blob_with_filepath
=== CONT TestAccDataFactoryDatasetBinary_blob_with_filepath
--- PASS: TestAccDataFactoryDatasetBinary_blob_with_filepath (256.06s)
=== RUN TestAccDataFactoryDatasetBinary_http
=== PAUSE TestAccDataFactoryDatasetBinary_http
=== CONT TestAccDataFactoryDatasetBinary_http
--- PASS: TestAccDataFactoryDatasetBinary_http (175.27s)
=== RUN TestAccDataFactoryDatasetBinary_sftp
=== PAUSE TestAccDataFactoryDatasetBinary_sftp
=== CONT TestAccDataFactoryDatasetBinary_sftp
--- PASS: TestAccDataFactoryDatasetBinary_sftp (237.02s)
=== RUN TestAccDataFactoryDatasetBinary_sftpComplete
=== PAUSE TestAccDataFactoryDatasetBinary_sftpComplete
=== CONT TestAccDataFactoryDatasetBinary_sftpComplete
--- PASS: TestAccDataFactoryDatasetBinary_sftpComplete (239.05s)
PASS

=== RUN TestAccDataFactoryDatasetJSON_basic
=== PAUSE TestAccDataFactoryDatasetJSON_basic
=== CONT TestAccDataFactoryDatasetJSON_basic
--- PASS: TestAccDataFactoryDatasetJSON_basic (176.10s)
=== RUN TestAccDataFactoryDatasetJSON_update
=== PAUSE TestAccDataFactoryDatasetJSON_update
=== CONT TestAccDataFactoryDatasetJSON_update
--- PASS: TestAccDataFactoryDatasetJSON_update (278.44s)
=== RUN TestAccDataFactoryDatasetJSON_blob
=== PAUSE TestAccDataFactoryDatasetJSON_blob
=== CONT TestAccDataFactoryDatasetJSON_blob
--- PASS: TestAccDataFactoryDatasetJSON_blob (256.97s)
PASS

=== RUN TestAccDataFactoryDatasetParquet_http
=== PAUSE TestAccDataFactoryDatasetParquet_http
=== CONT TestAccDataFactoryDatasetParquet_http
--- PASS: TestAccDataFactoryDatasetParquet_http (239.87s)
=== RUN TestAccDataFactoryDatasetParquet_http_update
=== PAUSE TestAccDataFactoryDatasetParquet_http_update
=== CONT TestAccDataFactoryDatasetParquet_http_update
--- PASS: TestAccDataFactoryDatasetParquet_http_update (351.81s)
=== RUN TestAccDataFactoryDatasetParquet_blob
=== PAUSE TestAccDataFactoryDatasetParquet_blob
=== CONT TestAccDataFactoryDatasetParquet_blob
--- PASS: TestAccDataFactoryDatasetParquet_blob (260.20s)
PASS

@lonegunmanb
Copy link
Contributor Author

Close for #16350

@lonegunmanb lonegunmanb reopened this Apr 24, 2022
@lonegunmanb
Copy link
Contributor Author

lonegunmanb commented Apr 24, 2022

Reopen because #16350 was not suffcient. This pr could fix the test failures introduced by #16350 .

Hello @katbyte , if you think it's better to wait for #16350 to fix the tests then I'll be happy to close this pr, it's your call.

@gregops312
Copy link
Contributor

@lonegunmanb I saw your comments and links. I've updated my PR, you're right the only mistake was in the data_factory.go causing my test failures.

@gregops312
Copy link
Contributor

gregops312 commented Apr 25, 2022

This has been already solved by #16514

@lonegunmanb
Copy link
Contributor Author

Hi @GKMAN , thanks for the tips.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants