Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r\backup_protected_vm Add doc for destroy hanging #16443

Closed
wants to merge 1 commit into from

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Apr 19, 2022

Adding doc for #4276

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Apr 24, 2022

Hi @katbyte the soft-delete feature is added to service and tf support is added by #5586. The backup item can be destroyed properly when setting soft_delete_enabled to false on its azurerm_recovery_services_vault. However, it seems to be a service design that, when soft-delete is enabled, the deleted backup vm still remains in the list as a soft-delete state, causing the Get API to not return 404 and the deletion to timeout

@katbyte
Copy link
Collaborator

katbyte commented May 4, 2022

@myc2h6o - i feel like that is an API bug that should be resolved?

@myc2h6o
Copy link
Contributor Author

myc2h6o commented May 5, 2022

Hi @katbyte I've opened a new issue under Azure Spec Azure/azure-rest-api-specs#18921 describing the issue with the delete and compared it with the Key Vault Key delete api which also has the concept of soft-delete. If API doesn't change, to workaround this in provider, we need to add additional logic in Delete and CreateUpdate to mark the resource as non-exist when its property value of protectionState is ProtectionStopped. And in create, if it will recover a soft-deleted vm, we need to add a special property isRehydrate to undo the delete.
While waiting for the reply from service team, shall we add the note in this change to document so that others can get it from the doc?

@katbyte katbyte added the upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR label May 10, 2022
@mbfrahry
Copy link
Member

Closing this as it was superseded by #16939

@mbfrahry mbfrahry closed this May 26, 2022
@myc2h6o myc2h6o deleted the back_protected_vm_doc branch May 27, 2022 01:47
@myc2h6o
Copy link
Contributor Author

myc2h6o commented May 27, 2022

The workaround mentioned above is implemented by #16939, the doc update is not needed any more

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation size/XS upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants