cluster_node_pool/kubernetes_cluster remove node_labels forceNew

[qiqingzhang]

create a public pull request for cluster_node_pool/kubernetes_cluster remove node_labels forceNew

After removing force new, we tested the behavior of this property.

test result after update:
1: TestAccKubernetesCluster_defaultNodePool

2: TestAccKubernetesClusterNodePool_nodeLabels

[tombuildsstuff]

@heiazuo whilst this is true for newly provisioned clusters, is this behaviour consistent for clusters created previously (e.g. a month ago)? The behaviour of the AKS API depends on when the AKS Cluster was provisioned, fwiw - so a cluster created today can have different behaviours to a cluster from last week (and depends on the kubernetes version being used etc)

[grayzu]

@tombuildsstuff, I just pinged the AKS team and they said "So long as you’re using the newer rest API/SDK, it’s the same for any version."

[stephybun]

Thanks for this PR @heiazuo. The docs should be amended since the resource will no longer be recreated if the node labels are updated. Can you also please add a test that updates the node labels?

[ms-henglu]

Hi @stephybun , would you please take another look?

[stephybun]

@ms-henglu, a test that updates the node labels is still missing.

[qiqingzhang]

Hi @stephybun, the node labels test case already exists, we don't need to create

terraform-provider-azurerm/internal/services/containers/kubernetes_cluster_other_resource_test.go

Line 145 in f1aa78b

func TestAccKubernetesCluster_nodeLabels(t *testing.T) {

terraform-provider-azurerm/internal/services/containers/kubernetes_cluster_node_pool_resource_test.go

Line 371 in 95496b2

func TestAccKubernetesClusterNodePool_nodeLabels(t *testing.T) {

[stephybun]

Thanks @heiazuo, LGTM 👍

[github-actions]

This functionality has been released in v3.6.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.