Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resourece: azurerm_signalr_shared_private_link_resource #16187

Merged
merged 16 commits into from
Jul 29, 2022
Merged

New Resourece: azurerm_signalr_shared_private_link_resource #16187

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
32a6575
update sdk
xiaxyi Mar 30, 2022
1571440
update sdk
xiaxyi Mar 30, 2022
2d13d41
update
xiaxyi Mar 31, 2022
8c12be3
update
xiaxyi Mar 31, 2022
8c116b6
update
xiaxyi Mar 31, 2022
bf8939e
update sdk
xiaxyi Mar 31, 2022
b52f42c
update
xiaxyi Apr 1, 2022
873c5d2
fmt docs
xiaxyi Apr 1, 2022
8cfb36c
update
xiaxyi Apr 1, 2022
64b8ed0
update fmt
xiaxyi Apr 1, 2022
98795e0
updating upstream
xiaxyi Jul 5, 2022
587fe98
update
xiaxyi Jul 5, 2022
57d1637
merging upstream
xiaxyi Jul 20, 2022
78f2cd1
update sdk
xiaxyi Jul 20, 2022
f207e44
merging
xiaxyi Jul 22, 2022
5662c9b
Merge remote-tracking branch 'origin/signalr/spl' into signalr/spl
xiaxyi Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/services/signalr/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package client
import (
"github.com/Azure/azure-sdk-for-go/services/webpubsub/mgmt/2021-10-01/webpubsub"
"github.com/hashicorp/terraform-provider-azurerm/internal/common"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/signalr/sdk/2020-05-01/signalr"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/signalr/sdk/2021-10-01/signalr"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where's the upstream PR using this? I can only see 2020-05-01 upstream?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where's the upstream PR using this? I can only see 2020-05-01 upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombuildsstuff are you suggesting to raise a PR to upgrade the SDK only?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the service has now been moved over to go-azure-sdk, could we update the PR to reflect this?

)

type Client struct {
Expand Down
11 changes: 6 additions & 5 deletions internal/services/signalr/registration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,11 @@ func (r Registration) SupportedDataSources() map[string]*pluginsdk.Resource {
// SupportedResources returns the supported Resources supported by this Service
func (r Registration) SupportedResources() map[string]*pluginsdk.Resource {
return map[string]*pluginsdk.Resource{
"azurerm_signalr_service": resourceArmSignalRService(),
"azurerm_signalr_service_network_acl": resourceArmSignalRServiceNetworkACL(),
"azurerm_web_pubsub": resourceWebPubSub(),
"azurerm_web_pubsub_hub": resourceWebPubsubHub(),
"azurerm_web_pubsub_network_acl": resourceWebpubsubNetworkACL(),
"azurerm_signalr_service": resourceArmSignalRService(),
"azurerm_signalr_service_network_acl": resourceArmSignalRServiceNetworkACL(),
"azurerm_signalr_shared_private_link_resource": resourceSignalRSharedPrivateLinkResource(),
"azurerm_web_pubsub": resourceWebPubSub(),
"azurerm_web_pubsub_hub": resourceWebPubsubHub(),
"azurerm_web_pubsub_network_acl": resourceWebpubsubNetworkACL(),
}
}
15 changes: 15 additions & 0 deletions internal/services/signalr/sdk/2021-10-01/signalr/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package signalr

import "github.com/Azure/go-autorest/autorest"

type SignalRClient struct {
Client autorest.Client
baseUri string
}

func NewSignalRClientWithBaseURI(endpoint string) SignalRClient {
return SignalRClient{
Client: autorest.NewClientWithUserAgent(userAgent()),
baseUri: endpoint,
}
}
Loading