Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_service_plan - add support for zone_balancing_enabled #16156

Merged
merged 3 commits into from
Apr 6, 2022
Merged

azurerm_service_plan - add support for zone_balancing_enabled #16156

merged 3 commits into from
Apr 6, 2022

Conversation

jackofallops
Copy link
Member

closes #16095

@jackofallops jackofallops added this to the v3.1.0 milestone Mar 30, 2022
@jackofallops jackofallops requested a review from a team March 30, 2022 10:22
@jackofallops
Copy link
Member Author

Selection (includes some web apps and function apps) of tests looking good:

image

katbyte
katbyte approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚜

@sebader sebader mentioned this pull request Apr 1, 2022
Closed
1 task
@jackofallops jackofallops changed the title azurerm_service_plan - add support for availability_zone_balancing_enabled azurerm_service_plan - add support for zone_balancing_enabled Apr 4, 2022
@jackofallops jackofallops force-pushed the f/service-plan-zone-balancing branch from fa6e7b8 to 3b7c137 Compare April 5, 2022 07:42
tombuildsstuff
tombuildsstuff approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops jackofallops merged commit 09ccbbc into main Apr 6, 2022
@jackofallops jackofallops deleted the f/service-plan-zone-balancing branch April 6, 2022 08:57
jackofallops added a commit that referenced this pull request Apr 6, 2022
@jackofallops
Update for #16156
ef989aa
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This functionality has been released in v3.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/app-service size/S
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

azurerm_service_plan zone_redundant property
3 participants
@jackofallops @tombuildsstuff @katbyte