azurerm_resource_group - Wait for eventual consistency when deleting
#16073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbfrahry
changed the title
azurerm_resource_group Account for eventual consistency when deletingazurerm_resource_group - Wait for eventual consistency when deleting
katbyte
approved these changes
Mar 25, 2022
| return resourceGroupContainsItemsError(id.ResourceGroup, nestedResourceIds) | ||
| } | ||
| if len(nestedResourceIds) > 0 { | ||
| time.Sleep(15 * time.Second) |
There was a problem hiding this comment.
Suggested change
| time.Sleep(15 * time.Second) | |
| time.Sleep(30 * time.Second) |
| if val.ID != nil { | ||
| nestedResourceIds = append(nestedResourceIds, *val.ID) | ||
| // Resource groups sometimes hold on to resource information after the resources have been deleted. We'll retry this check to account for that eventual consistency. | ||
| err = pluginsdk.Retry(time.Minute*5, func() *pluginsdk.RetryError { |
There was a problem hiding this comment.
Suggested change
| err = pluginsdk.Retry(time.Minute*5, func() *pluginsdk.RetryError { | |
| err = pluginsdk.Retry(time.Minute*2, func() *pluginsdk.RetryError { |
|
This functionality has been released in v3.0.2 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new feature was added in 3.0 that checks to see if there are any resources being managed by a resource group before deleting that resource group. Unfortunately, it seems there is a bit of eventual consistency that causes the resource group to think those resources are still around when they have been deleted.
To fix that, we'll do that check a few times before we actually error out because the resources are still around.
Fixes #16069