Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback issues introduced in 48d9aadb1e1397d99fe3dc535a2e7c4928f441ae #15997

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Mar 24, 2022

This PR rolls back a bug introduced in 48d9aad, which causes the following config:

resource "azurerm_log_analytics_workspace" "test" {
  name                = "acctestLAW-220119092533317533"
  location            = azurerm_resource_group.test.location
  resource_group_name = azurerm_resource_group.test.name
  sku                 = "PerGB2018"
}

raises error:

│ Error: `reservation_capacity_in_gb_per_day` can only be used with the `CapacityReservation` SKU

This PR rolls back a bug introduced in hashicorp@48d9aad, which causes the following config:

```hcl
resource "azurerm_log_analytics_workspace" "test" {
  name                = "acctestLAW-220119092533317533"
  location            = azurerm_resource_group.test.location
  resource_group_name = azurerm_resource_group.test.name
  sku                 = "PerGB2018"
}
```

raises error:

```
│ Error: `reservation_capacity_in_gb_per_day` can only be used with the `CapacityReservation` SKU
```
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests look good 👍

@tombuildsstuff tombuildsstuff merged commit f74d027 into hashicorp:main Mar 24, 2022
@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants