`Dependency` New Resource azurerm_healthcare_fhir_service #15913

xiaxyi · 2022-03-21T16:07:21Z

Adding FHIR service (Fast Healthcare Interoperability Resources) for the azure healthcare api2.0

The healthcare industry is rapidly transforming health data to the emerging standard of FHIR

FHIR service in Azure Health Data Services (hereby called the FHIR service) enables rapid exchange of data through Fast Healthcare Interoperability Resources (FHIR®) APIs, backed by a managed Platform-as-a Service (PaaS) offering in the cloud.

Dependency of pr #15759
acc tests:

--- PASS: TestAccHealthCareFhirServiceDataSource_basic (903.25s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/healthcare    903.940s

--- PASS: TestAccHealthcareApiFhirService_basic (875.40s)
--- PASS: TestAccHealthcareApiFhirService_requiresImport (923.26s)
--- PASS: TestAccHealthcareApiFhirService_complete (978.85s)
--- PASS: TestAccHealthcareApiFhirService_updateIdentity (1177.58s)
--- PASS: TestAccHealthcareApiFhirService_updateAcrLoginServer (2527.39s)
--- PASS: TestAccHealthcareApiFhirService_updateCors (2618.35s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/healthcare    2619.134s

internal/services/healthcare/healthcare_fhir_resource.go

katbyte · 2022-05-09T19:54:27Z

internal/services/healthcare/healthcare_fhir_resource.go

+						},
+						"max_age_in_seconds": {


internal/services/healthcare/healthcare_fhir_resource_test.go

katbyte · 2022-05-09T19:55:11Z

internal/services/healthcare/healthcare_fhir_resource_test.go

+  kind                = "fhir-R4"
+  authentication {
+    authority = "https://login.microsoftonline.com/72f988bf-86f1-41af-91ab-2d7cd011db47"
+    audience  = "https://acctestfhir.fhir.azurehealthcareapis.com"
+  }
+  identity {
+    type = "SystemAssigned"
+  }
+  depends_on = [azurerm_healthcare_workspace.test]


how come we need a depends on here? this is often a sign of poor design

internal/services/healthcare/healthcare_fhir_resource_test.go

katbyte · 2022-05-09T19:56:36Z

website/docs/r/healthcare_fhir_service.html.markdown

+* `allowed_headers` - (Required) A set of headers to be allowed via CORS.
+* `allowed_methods` - (Required) The methods to be allowed via CORS.
+* `max_age_in_seconds` - (Required) The max age to be allowed via CORS.
+* `allow_credentials` - (Boolean) If credentials are allowed via CORS.


could we make this

Suggested change

* `allow_credentials` - (Boolean) If credentials are allowed via CORS.

* `credentials_allowed` - (Boolean) If credentials are allowed via CORS.

also we do not add boolean here, this should be optional or required

Suggested change

* `allow_credentials` - (Boolean) If credentials are allowed via CORS.

* `allow_credentials` - (optional|required) If credentials are allowed via CORS.

I used the same property definition from the existing resource healthcare_service, should I change that resource too?

katbyte · 2022-05-09T19:58:45Z

website/docs/r/healthcare_fhir_service.html.markdown

+
+* `authentication` - (Required) An `authentication` block as defined below.
+
+* `export_storage_account_name` - (Optional) specifies the name of the export storage account which accepts the operation configuration information


grammer, caps, punciation

Suggested change

* `export_storage_account_name` - (Optional) specifies the name of the export storage account which accepts the operation configuration information

* `export_storage_account_name` - (Optional) Specifies the name of the storage account which the operation configuration information is exported to.

please fix all documentation grammer, caps and punctuation.

also this property is unclear, maybe it should be configuration_export_storage_account_name

xiaxyi · 2022-05-12T23:49:32Z

@katbyte Thanks for the comments, updated the code

katbyte · 2022-05-18T01:10:54Z

internal/services/healthcare/healthcare_fhir_resource.go

+			"identity": commonschema.SystemAssignedIdentityOptional(),
+
+			// can't use the registry ID due to the ID cannot be obtained when setting the property in state file
+			"acr_login_servers": {


what is this property? name? url? id? can we put what the user hsould supply in the name?

Suggested change

"acr_login_servers": {

"acr_login_server_urls": {

renamed to container_registry_login_server_url since it's the login server url of azure container registry

katbyte · 2022-05-18T01:11:08Z

internal/services/healthcare/healthcare_fhir_resource.go

+				},
+			},
+
+			"cors_configuration": {


configuration is redundant

Suggested change

"cors_configuration": {

"cors": {

updated, will change existing healthcare_service_resource.go as well

katbyte

LGTM 🦋

github-actions · 2022-05-20T07:49:06Z

This functionality has been released in v3.7.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-06-20T02:29:35Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

xiaxyi added 13 commits January 28, 2022 15:33

add pandora sdk for healthcare api

912d448

merge

fe68c9c

add workspace

b9c5400

workspace

8ca66de

fhir

ef43a27

fhir

3e930d3

fhir

cbc8841

fhir cors

7e8f15e

fhir

67dce19

update

2b26b3f

fhir

40f0d88

update

0d02e16

fhir

b4839d2

github-actions bot added documentation service/api-management service/app-service service/healthcare size/XL labels Mar 21, 2022

xiaxyi marked this pull request as draft March 21, 2022 16:08

fhir update

cf0c096

github-actions bot added the service/recovery-services label Mar 22, 2022

update fmt

f9e1daf

xiaxyi marked this pull request as ready for review March 22, 2022 06:40

xiaxyi added 3 commits March 23, 2022 10:18

update fhir

1f0d0d6

update docs

61f2221

update status

ca0225c

xiaxyi changed the title ~~New Resource Fhir service for Healthcare workspace~~ Dependency New Resource Fhir service for Healthcare workspace Mar 29, 2022

xiaxyi added 3 commits March 29, 2022 11:01

update docs

a0334e4

update fmt

e735aaa

Merge remote-tracking branch 'upstream/main' into hc/fhirService

dcd3eab

xiaxyi added 2 commits March 29, 2022 13:24

Merge remote-tracking branch 'upstream/main' into hc/fhirService

2ad9dfb

update docs

9bf3285

github-actions bot removed the service/recovery-services label Mar 29, 2022

update

35d837f

This comment was marked as off-topic.

Sign in to view

â�resolve conflicts

b85d3a5

katbyte requested changes May 9, 2022

View reviewed changes

xiaxyi and others added 6 commits May 10, 2022 09:22

merge

1a563be

update

35e04ae

update test case

3306563

Delete main.tf

15e3b19

update fmt

d0d4ecc

Merge remote-tracking branch 'origin/healthcareapi/fhir' into hc/fhir

7a6c0ae

Merge remote-tracking branch 'upstream/main' into hc/fhir

5292941

katbyte requested changes May 18, 2022

View reviewed changes

xiaxyi added 3 commits May 18, 2022 14:52

update per review

92999e1

Merge remote-tracking branch 'upstream/main' into hc/fhir

11cb3c2

update network

6fb968f

katbyte changed the title ~~Dependency New Resource Fhir service for Healthcare workspace~~ Dependency New Resource azurerm_healthcare_fhir_service May 20, 2022

katbyte approved these changes May 20, 2022

View reviewed changes

katbyte merged commit 67f7318 into hashicorp:main May 20, 2022

katbyte added a commit that referenced this pull request May 20, 2022

CHANGELOG #15913

8630929

github-actions bot added this to the v3.7.0 milestone May 20, 2022

github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022

xiaxyi deleted the healthcareapi/fhir branch August 14, 2022 00:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Dependency` New Resource azurerm_healthcare_fhir_service #15913

`Dependency` New Resource azurerm_healthcare_fhir_service #15913

xiaxyi commented Mar 21, 2022 •

edited

Loading

This comment was marked as off-topic.

katbyte May 9, 2022

katbyte May 9, 2022

katbyte May 9, 2022

katbyte May 9, 2022

xiaxyi May 10, 2022

katbyte May 18, 2022

katbyte May 9, 2022

xiaxyi commented May 12, 2022

katbyte May 18, 2022

xiaxyi May 18, 2022 •

edited

Loading

katbyte May 18, 2022

xiaxyi May 18, 2022

katbyte left a comment

github-actions bot commented May 20, 2022

github-actions bot commented Jun 20, 2022

	* `allow_credentials` - (Boolean) If credentials are allowed via CORS.
	* `credentials_allowed` - (Boolean) If credentials are allowed via CORS.

	* `allow_credentials` - (Boolean) If credentials are allowed via CORS.
	* `allow_credentials` - (optional\|required) If credentials are allowed via CORS.


		* `authentication` - (Required) An `authentication` block as defined below.

		* `export_storage_account_name` - (Optional) specifies the name of the export storage account which accepts the operation configuration information

Dependency New Resource azurerm_healthcare_fhir_service #15913

Dependency New Resource azurerm_healthcare_fhir_service #15913

Conversation

xiaxyi commented Mar 21, 2022 • edited Loading

This comment was marked as off-topic.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xiaxyi commented May 12, 2022

Choose a reason for hiding this comment

xiaxyi May 18, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented May 20, 2022

github-actions bot commented Jun 20, 2022

`Dependency` New Resource azurerm_healthcare_fhir_service #15913

`Dependency` New Resource azurerm_healthcare_fhir_service #15913

xiaxyi commented Mar 21, 2022 •

edited

Loading

xiaxyi May 18, 2022 •

edited

Loading