Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: azurerm_key_vault_encrypted_value #15873

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Mar 18, 2022

$ TF_ACC=1 go test -v ./internal/services/keyvault -run=TestAccEncryptedValueDataSource_
=== RUN   TestAccEncryptedValueDataSource_encryptAndDecrypt
=== PAUSE TestAccEncryptedValueDataSource_encryptAndDecrypt
=== CONT  TestAccEncryptedValueDataSource_encryptAndDecrypt
--- PASS: TestAccEncryptedValueDataSource_encryptAndDecrypt (274.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/keyvault	276.443s

This PR supersedes #8895 by converting this into a Data Source rather than a Resource which handles the bi-directional conversion of encrypted/decrypted values as necessary.

```
$ TF_ACC=1 go test -v ./internal/services/keyvault -run=TestAccEncryptedValueDataSource_
=== RUN   TestAccEncryptedValueDataSource_encryptAndDecrypt
=== PAUSE TestAccEncryptedValueDataSource_encryptAndDecrypt
=== CONT  TestAccEncryptedValueDataSource_encryptAndDecrypt
--- PASS: TestAccEncryptedValueDataSource_encryptAndDecrypt (274.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/keyvault	276.443s
```

This commit supersedes #8895 by converting this into a Data Source rather than a Resource which handles the bi-directional
conversion of encrypted/decrypted values as necessary.
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🫖

@tombuildsstuff tombuildsstuff merged commit 47b9242 into main Mar 22, 2022
@tombuildsstuff tombuildsstuff deleted the f/encrypted-value branch March 22, 2022 08:05
tombuildsstuff added a commit that referenced this pull request Mar 22, 2022
@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants