Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New data source 'azurerm_azuread_group' #1585

Closed

Conversation

tiwood
Copy link
Contributor

@tiwood tiwood commented Jul 16, 2018

This PR adds a new data source for 'azurerm_azuread_group'.

  • New data source
  • Add markdown documentation
  • Add tests (as these are my first steps with Go, I'm not yet sure how to do this.)

Example Usage (by Object ID)

data "azurerm_azuread_group" "test_group" {
  object_id = "78722cfc-8946-11e8-95f1-2200ec79ad01"
}

Example Usage (by Group Display Name)

data "azurerm_azuread_group" "test_group" {
  display_name = "MyTestGroup"
}

The following attributes are exported:

  • id - The Object ID for the Azure AD Group.
  • display_name - The Display Name for the Azure AD Group.
  • security_enabled - True or False depending if the Azure AD Group is security enabled.

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiwood Thanks for this PR, it mostly LGTM but if you could add some test cases and resolve the conflicts that would be great.

@tiwood
Copy link
Contributor Author

tiwood commented Aug 29, 2018

Hi @jeffreyCline, I created a new PR which contains this data source (updated logic) and a resource to create groups, as well as the requested acc tests.

I think we can close this PR in favour of #1839

@tiwood tiwood closed this Sep 11, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants