`azurerm_security_center_server_vulnerability_assessment` - deprecate in favour of `azurerm_security_center_vm_server_vulnerability_assessment` #15747

catriona-m · 2022-03-08T18:03:38Z

No description provided.

katbyte · 2022-03-10T07:15:42Z

internal/services/securitycenter/registration.go

+		"azurerm_security_center_vm_server_vulnerability_assessment":        resourceVMServerVulnerabilityAssessment(),
+		"azurerm_security_center_hybrid_vm_server_vulnerability_assessment": resourceHybridVMServerVulnerabilityAssessment(),


would it make sense to name these

Suggested change

"azurerm_security_center_vm_server_vulnerability_assessment": resourceVMServerVulnerabilityAssessment(),

"azurerm_security_center_hybrid_vm_server_vulnerability_assessment": resourceHybridVMServerVulnerabilityAssessment(),

"azurerm_security_center_vm_vulnerability_assessment_server": resourceVMServerVulnerabilityAssessment(),

"azurerm_security_center_server_vulnerability_assessment_hybrid_vm": resourceHybridVMServerVulnerabilityAssessment(),

so its service/thing/catagory of thing and when sorting things alphabetically they end up next to each other?

good idea - changed now!

tombuildsstuff

hey @catriona-m

Thanks for pushing those changes - I've taken a look through and left some comments inline but this is otherwise looking good 👍

Thanks!

tombuildsstuff · 2022-03-10T12:20:12Z

internal/services/securitycenter/registration.go

+		"azurerm_security_center_automation":                                resourceSecurityCenterAutomation(),
+		"azurerm_security_center_auto_provisioning":                         resourceSecurityCenterAutoProvisioning(),
+		"azurerm_security_center_server_vulnerability_assessment":           resourceServerVulnerabilityAssessment(),
+		"azurerm_security_center_server_vulnerability_assessment_hybrid_vm": resourceServerVulnerabilityAssessmentHybridVM(),


"Hybrid" is actually "Arc", so this wants to be:

Suggested change

"azurerm_security_center_server_vulnerability_assessment_hybrid_vm": resourceServerVulnerabilityAssessmentHybridVM(),

"azurerm_security_center_server_vulnerability_arc_virtual_machine_assessment": resourceServerVulnerabilityAssessmentHybridVM(),

tombuildsstuff · 2022-03-10T12:20:26Z

internal/services/securitycenter/registration.go

+		"azurerm_security_center_auto_provisioning":                         resourceSecurityCenterAutoProvisioning(),
+		"azurerm_security_center_server_vulnerability_assessment":           resourceServerVulnerabilityAssessment(),
+		"azurerm_security_center_server_vulnerability_assessment_hybrid_vm": resourceServerVulnerabilityAssessmentHybridVM(),
+		"azurerm_security_center_server_vulnerability_assessment_vm":        resourceServerVulnerabilityAssessmentVM(),


can we spell this out a little:

Suggested change

"azurerm_security_center_server_vulnerability_assessment_vm": resourceServerVulnerabilityAssessmentVM(),

"azurerm_security_center_server_vulnerability_virtual_machine_assessment": resourceServerVulnerabilityAssessmentVM(),

tombuildsstuff · 2022-03-10T12:23:15Z

...ervices/securitycenter/security_center_server_vulnerability_assessment_hybrid_vm_resource.go

+		// TODO: replace this with an importer which validates the ID during import
+		Importer: &schema.ResourceImporter{
+			StateContext: schema.ImportStatePassthroughContext,
+		},


could we add a custom importer which validates the Resource ID and confirms that this is a Hybrid VM? I can't make a suggestion for some reason, but that'd be pluginsdk.ImporterValidatingResourceId

tombuildsstuff · 2022-03-10T12:24:06Z

...ervices/securitycenter/security_center_server_vulnerability_assessment_hybrid_vm_resource.go

+	vulnerabilityAssessment, err := client.Get(ctx, hybridMachineId.ResourceGroup, hybridProvider, hybridType, hybridMachineId.MachineName)
+	if err != nil {
+		if !utils.ResponseWasNotFound(vulnerabilityAssessment.Response) {
+			return fmt.Errorf("checking for presence of existing Advanced Threat Protection for %s: %+v", *hybridMachineId, err)
+		}
+	}
+
+	if vulnerabilityAssessment.ID != nil && *vulnerabilityAssessment.ID != "" {
+		return tf.ImportAsExistsError("azurerm_security_center_server_vulnerability_assessment_hybrid_vm", *vulnerabilityAssessment.ID)
+	}
+
+	vulnerabilityAssessment, err = client.CreateOrUpdate(ctx, hybridMachineId.ResourceGroup, hybridProvider, hybridType, hybridMachineId.MachineName)
+	if err != nil {
+		return fmt.Errorf("create Server Vulnerability Assessment for %s: %+v", *hybridMachineId, err)
+	}
+
+	if vulnerabilityAssessment.ID != nil {
+		d.SetId(*vulnerabilityAssessment.ID)
+	}


rather than using the Resource ID returned from the API here can we instead define a Resource ID (resourceids.go) and use that here instead?

tombuildsstuff · 2022-03-10T12:24:53Z

...ervices/securitycenter/security_center_server_vulnerability_assessment_hybrid_vm_resource.go

+	hybridMachineId, err := computeParse.HybridMachineID(d.Get("hybrid_machine_id").(string))
+	if err != nil {
+		return err
+	}
+
+	resp, err := client.Get(ctx, hybridMachineId.ResourceGroup, hybridProvider, hybridType, hybridMachineId.MachineName)


(similar to above) can we use the HybridVM Resource ID and then parse d.ID() instead?

We can't guarantee in the Read function that the schema fields are available, so there's a crash here

tombuildsstuff · 2022-03-10T12:27:33Z

internal/services/securitycenter/security_center_server_vulnerability_assessment_vm_resource.go

+		return fmt.Errorf("retrieving Server Vulnerability Assessment status for %s: %+v", *virtualMachineId, err)
+	}
+
+	d.SetId(*resp.ID)


(as above)

Suggested change

d.SetId(*resp.ID)

tombuildsstuff · 2022-03-10T12:27:41Z

internal/services/securitycenter/security_center_server_vulnerability_assessment_vm_resource.go

+	ctx, cancel := timeouts.ForDelete(meta.(*clients.Client).StopContext, d)
+	defer cancel()
+
+	virtualMachineId, err := computeParse.VirtualMachineID(d.Get("virtual_machine_id").(string))


tombuildsstuff · 2022-03-10T12:27:47Z

internal/services/securitycenter/security_center_server_vulnerability_assessment_vm_resource.go

+	// Can not delete if still in provisioning state. Wait for it to complete.
+	for retry := 1; retry <= 20; retry++ {
+		response, err := client.Get(ctx, virtualMachineId.ResourceGroup, computeProvider, vmType, virtualMachineId.Name)
+		if err != nil || response.ProvisioningState != security.ProvisioningState1Provisioning {
+			break
+		}
+		time.Sleep(time.Duration(retry) * time.Second)
+	}


tombuildsstuff · 2022-03-10T12:27:52Z

internal/services/securitycenter/security_center_server_vulnerability_assessment_vm_resource.go

+		time.Sleep(time.Duration(retry) * time.Second)
+	}
+
+	future, err := client.Delete(ctx, virtualMachineId.ResourceGroup, computeProvider, vmType, virtualMachineId.Name)


tombuildsstuff · 2022-03-10T12:28:59Z

website/docs/r/security_center_hybrid_vm_server_vulnerability_assessment.html.markdown

+Manages an Azure Server Vulnerability Assessment (Qualys) to a VM.
+
+-> **NOTE** Azure Defender has to be enabled on the subscription in order for this resource to work.
+See this [documentation](https://docs.microsoft.com/en-us/azure/security-center/security-center-get-started) to get started.


fwiw if we remove the language here it'll redirect to the users locale if available in that language

Suggested change

See this [documentation](https://docs.microsoft.com/en-us/azure/security-center/security-center-get-started) to get started.

See this [documentation](https://docs.microsoft.com/azure/security-center/security-center-get-started) to get started.

tombuildsstuff

hey @catriona-m

Thanks for pushing those changes - I've taken a look through and left some more comments inline, most of them are similar between the two resources but if we can fix those up then this should otherwise be good to go 👍

Thanks!

tombuildsstuff · 2022-03-16T10:43:18Z

...curitycenter/security_center_server_vulnerability_assessment_arc_virtual_machine_resource.go

+	vulnerabilityAssessment, err := client.Get(ctx, hybridMachineId.ResourceGroup, hybridProvider, hybridType, hybridMachineId.MachineName)
+	if err != nil {
+		if !utils.ResponseWasNotFound(vulnerabilityAssessment.Response) {
+			return fmt.Errorf("checking for presence of existing Advanced Threat Protection for %s: %+v", *hybridMachineId, err)
+		}
+	}
+
+	if vulnerabilityAssessment.ID != nil && *vulnerabilityAssessment.ID != "" {
+		return tf.ImportAsExistsError("azurerm_security_center_server_vulnerability_assessment_arc_virtual_machine", *vulnerabilityAssessment.ID)
+	}
+
+	vulnerabilityAssessment, err = client.CreateOrUpdate(ctx, hybridMachineId.ResourceGroup, hybridProvider, hybridType, hybridMachineId.MachineName)
+	if err != nil {
+		return fmt.Errorf("create Server Vulnerability Assessment for %s: %+v", *hybridMachineId, err)
+	}
+
+	id := parse.NewVulnerabilityAssessmentVmID(hybridMachineId.SubscriptionId, hybridMachineId.ResourceGroup, hybridMachineId.MachineName, "Default")
+	d.SetId(id.ID())
+
+	timeout, _ := ctx.Deadline()
+	stateConf := &pluginsdk.StateChangeConf{
+		Pending:      []string{"Pending"},
+		Target:       []string{"Succeeded"},
+		Refresh:      serverVulnerabilityAssessmentArcVirtualMachineStateRefreshFunc(ctx, client, id.ResourceGroup, id.VirtualMachineName),
+		PollInterval: 10 * time.Second,
+		Timeout:      time.Until(timeout),
+	}
+
+	if _, err := stateConf.WaitForStateContext(ctx); err != nil {
+		return fmt.Errorf("waiting for the completion of the creating/updating of %s: %+v", id, err)
+	}


A few things to note here:

The Resource ID defined in TF should be defined at the top so it can be used through the other items (error messages, requires import etc)

The ID shouldn't be set until we're sure the Resource has been created (consistency with other resources)

We can lean on the ID for error messages here fwiw

Suggested change

vulnerabilityAssessment, err := client.Get(ctx, hybridMachineId.ResourceGroup, hybridProvider, hybridType, hybridMachineId.MachineName)

if err != nil {

if !utils.ResponseWasNotFound(vulnerabilityAssessment.Response) {

return fmt.Errorf("checking for presence of existing Advanced Threat Protection for %s: %+v", *hybridMachineId, err)

}

}

if vulnerabilityAssessment.ID != nil && *vulnerabilityAssessment.ID != "" {

return tf.ImportAsExistsError("azurerm_security_center_server_vulnerability_assessment_arc_virtual_machine", *vulnerabilityAssessment.ID)

}

vulnerabilityAssessment, err = client.CreateOrUpdate(ctx, hybridMachineId.ResourceGroup, hybridProvider, hybridType, hybridMachineId.MachineName)

if err != nil {

return fmt.Errorf("create Server Vulnerability Assessment for %s: %+v", *hybridMachineId, err)

}

id := parse.NewVulnerabilityAssessmentVmID(hybridMachineId.SubscriptionId, hybridMachineId.ResourceGroup, hybridMachineId.MachineName, "Default")

d.SetId(id.ID())

timeout, _ := ctx.Deadline()

stateConf := &pluginsdk.StateChangeConf{

Pending: []string{"Pending"},

Target: []string{"Succeeded"},

Refresh: serverVulnerabilityAssessmentArcVirtualMachineStateRefreshFunc(ctx, client, id.ResourceGroup, id.VirtualMachineName),

PollInterval: 10 * time.Second,

Timeout: time.Until(timeout),

}

if _, err := stateConf.WaitForStateContext(ctx); err != nil {

return fmt.Errorf("waiting for the completion of the creating/updating of %s: %+v", id, err)

}

id := parse.NewVulnerabilityAssessmentVmID(hybridMachineId.SubscriptionId, hybridMachineId.ResourceGroup, hybridMachineId.MachineName, "Default")

vulnerabilityAssessment, err := client.Get(ctx, id.ResourceGroup, hybridProvider, hybridType, id.MachineName)

if err != nil {

if !utils.ResponseWasNotFound(vulnerabilityAssessment.Response) {

return fmt.Errorf("checking for presence of existing %s: %+v", id, err)

}

}

if !utils.ResponseWasNotFound(vulnerabilityAssessment.Response) {

return tf.ImportAsExistsError("azurerm_security_center_server_vulnerability_assessment_arc_virtual_machine", id.ID())

}

vulnerabilityAssessment, err = client.CreateOrUpdate(ctx, hybridMachineId.ResourceGroup, hybridProvider, hybridType, hybridMachineId.MachineName)

if err != nil {

return fmt.Errorf("creating %s: %+v", id, err)

}

timeout, _ := ctx.Deadline()

stateConf := &pluginsdk.StateChangeConf{

Pending: []string{"Pending"},

Target: []string{"Succeeded"},

Refresh: serverVulnerabilityAssessmentArcVirtualMachineStateRefreshFunc(ctx, client, id.ResourceGroup, id.VirtualMachineName),

PollInterval: 10 * time.Second,

Timeout: time.Until(timeout),

}

if _, err := stateConf.WaitForStateContext(ctx); err != nil {

return fmt.Errorf("waiting for the completion of the creating/updating of %s: %+v", id, err)

}

d.SetId(id.ID())

tombuildsstuff · 2022-03-16T10:50:16Z

...curitycenter/security_center_server_vulnerability_assessment_arc_virtual_machine_resource.go

+	var hybridMachineId *computeParse.HybridMachineId
+	if id.ID() != "" {
+		newHybridMachineId := computeParse.NewHybridMachineID(id.SubscriptionId, id.ResourceGroup, id.VirtualMachineName)
+		hybridMachineId = &newHybridMachineId
+	} else {
+		newHybridMachineId, err := computeParse.HybridMachineID(d.Get("hybrid_machine_id").(string))
+		if err != nil {
+			return err
+		}
+		hybridMachineId = newHybridMachineId
+	}


the Read function should only be using the ID field, other fields in the state can't be guaranteed (import/read time)

Suggested change

var hybridMachineId *computeParse.HybridMachineId

if id.ID() != "" {

newHybridMachineId := computeParse.NewHybridMachineID(id.SubscriptionId, id.ResourceGroup, id.VirtualMachineName)

hybridMachineId = &newHybridMachineId

} else {

newHybridMachineId, err := computeParse.HybridMachineID(d.Get("hybrid_machine_id").(string))

if err != nil {

return err

}

hybridMachineId = newHybridMachineId

}

hybridMachineId := computeParse.NewHybridMachineID(id.SubscriptionId, id.ResourceGroup, id.VirtualMachineName)

tombuildsstuff · 2022-03-16T10:51:55Z

...curitycenter/security_center_server_vulnerability_assessment_arc_virtual_machine_resource.go

+	// Cannot delete if still in provisioning state. Wait for it to complete.
+	timeout, _ := ctx.Deadline()
+	stateConf := &pluginsdk.StateChangeConf{
+		Pending:      []string{"Pending"},
+		Target:       []string{"Succeeded"},
+		Refresh:      serverVulnerabilityAssessmentArcVirtualMachineStateRefreshFunc(ctx, client, id.ResourceGroup, id.VirtualMachineName),
+		PollInterval: 10 * time.Second,
+		Timeout:      time.Until(timeout),
+	}
+
+	if _, err := stateConf.WaitForStateContext(ctx); err != nil {
+		return fmt.Errorf("waiting for the completion of the creation of %s: %+v", id, err)
+	}


this would indicate a bug elsewhere we need to track down, so this needs to be removed:

Suggested change

// Cannot delete if still in provisioning state. Wait for it to complete.

timeout, _ := ctx.Deadline()

stateConf := &pluginsdk.StateChangeConf{

Pending: []string{"Pending"},

Target: []string{"Succeeded"},

Refresh: serverVulnerabilityAssessmentArcVirtualMachineStateRefreshFunc(ctx, client, id.ResourceGroup, id.VirtualMachineName),

PollInterval: 10 * time.Second,

Timeout: time.Until(timeout),

}

if _, err := stateConf.WaitForStateContext(ctx); err != nil {

return fmt.Errorf("waiting for the completion of the creation of %s: %+v", id, err)

}

tombuildsstuff · 2022-03-16T10:58:17Z

...s/securitycenter/security_center_server_vulnerability_assessment_virtual_machine_resource.go

+			Create: pluginsdk.DefaultTimeout(5 * time.Minute),
+			Read:   pluginsdk.DefaultTimeout(5 * time.Minute),
+			Delete: pluginsdk.DefaultTimeout(10 * time.Minute),


just double-checking: given the polling below are these times accurate?

...curitycenter/security_center_server_vulnerability_assessment_arc_virtual_machine_resource.go

tombuildsstuff · 2022-03-16T11:21:07Z

website/docs/r/security_center_hybrid_vm_server_vulnerability_assessment.html.markdown

+
+The following arguments are supported:
+
+* `hybrid_machine_id` - (Required) The ID of the Azure ARC server to be monitored by vulnerability assessment. Changing this forces a new resource to be created.


Suggested change

* `hybrid_machine_id` - (Required) The ID of the Azure ARC server to be monitored by vulnerability assessment. Changing this forces a new resource to be created.

* `hybrid_machine_id` - (Required) The ID of the Arc Virtual Machine which should have a Vulnerability Assessment configured. Changing this forces a new resource to be created.

tombuildsstuff · 2022-03-16T11:21:45Z

website/docs/r/security_center_hybrid_vm_server_vulnerability_assessment.html.markdown

+* `id` - The ID of the Vulnerability Assessment resource.
+
+## Timeouts
+
+The `timeouts` block allows you to specify [timeouts](https://www.terraform.io/docs/configuration/resources.html#timeouts) for certain actions:
+
+* `create` - (Defaults to 5 minutes) Used when creating the Advanced Threat Protection.
+* `read` - (Defaults to 5 minutes) Used when retrieving the Advanced Threat Protection.
+* `delete` - (Defaults to 10 minutes) Used when deleting the Advanced Threat Protection.
+
+## Import
+
+Server Vulnerability Assessments can be imported using the `resource id`, e.g.


there's three different names listed here, can we standardize this on "Arc Virtual Machine Server Vulnerability Assessment"?

tombuildsstuff · 2022-03-16T11:26:19Z

website/docs/r/security_center_vm_server_vulnerability_assessment.html.markdown

+* `virtual_machine_id` - (Required) The ID of the virtual machine to be monitored by vulnerability assessment. Changing this forces a new resource to be created.
+
+## Attributes Reference
+
+In addition to all arguments above, the following attributes are exported:
+
+* `id` - The ID of the Vulnerability Assessment resource.
+
+## Timeouts
+
+The `timeouts` block allows you to specify [timeouts](https://www.terraform.io/docs/configuration/resources.html#timeouts) for certain actions:
+
+* `create` - (Defaults to 5 minutes) Used when creating the Advanced Threat Protection.
+* `read` - (Defaults to 5 minutes) Used when retrieving the Advanced Threat Protection.
+* `delete` - (Defaults to 10 minutes) Used when deleting the Advanced Threat Protection.
+
+## Import
+
+Server Vulnerability Assessments can be imported using the `resource id`, e.g.


(as above) can we make these names consistent?

tombuildsstuff · 2022-03-16T11:26:37Z

website/docs/r/security_center_vm_server_vulnerability_assessment.html.markdown

+  Manages an Azure Vulnerability Assessment (Qualys) to a VM.
+---
+
+# azurerm_security_center_vm_server_vulnerability_assessment
+
+Manages an Azure Server Vulnerability Assessment (Qualys) to a VM.


we expand vm to virtual_machine fwiw

tombuildsstuff · 2022-03-16T11:27:01Z

website/docs/r/security_center_vm_server_vulnerability_assessment.html.markdown

+Manages an Azure Server Vulnerability Assessment (Qualys) to a VM.
+
+-> **NOTE** Azure Defender has to be enabled on the subscription in order for this resource to work.
+See this [documentation](https://docs.microsoft.com/en-us/azure/security-center/security-center-get-started) to get started.


(as above) removing the language here will redirect to the article in the users locale if available

Suggested change

See this [documentation](https://docs.microsoft.com/en-us/azure/security-center/security-center-get-started) to get started.

See this [documentation](https://docs.microsoft.com/azure/security-center/security-center-get-started) to get started.

…parate resources

tombuildsstuff · 2022-03-23T20:39:35Z

Rebased.

…lity_assessment_arc_virtual_machine` for the moment We can't currently test `security_center_server_vulnerability_assessment_arc_virtual_machine` as it requires provisioning a Hybrid Virtual Machine which we don't currently support - so I've opened #15990 to track support for that.

tombuildsstuff

Left a couple of comments that I've pushed a couple of commits for - but this otherwise LGTM 👍

I've removed the azurerm_security_center_server_vulnerability_assessment_arc_virtual_machine resource since we can't current provision Hybrid Virtual Machines (which is a dependency for testing this) - support for which is being tracked in #15990

...curitycenter/security_center_server_vulnerability_assessment_arc_virtual_machine_resource.go

katbyte

LGTM ☔

…sment` in the upgrade guide

github-actions · 2022-03-24T15:23:33Z

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-04-24T02:19:58Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

catriona-m added the deprecation label Mar 8, 2022

catriona-m requested a review from a team March 8, 2022 18:03

github-actions bot added documentation service/security-center size/XL labels Mar 8, 2022

katbyte reviewed Mar 10, 2022

View reviewed changes

tombuildsstuff suggested changes Mar 10, 2022

View reviewed changes

tombuildsstuff suggested changes Mar 16, 2022

View reviewed changes

tombuildsstuff added this to the v3.0.0 milestone Mar 22, 2022

tombuildsstuff mentioned this pull request Mar 23, 2022

3.0: adding missing import validators #15989

Merged

catriona-m added 8 commits March 23, 2022 21:37

split azurerm_security_center_server_vulnerability_assessment into se…

1109258

…parate resources

linting fixes

2a70387

update doc

a2dce1d

update doc

2308485

changed names

c4608ff

added import parsers and state refresh

31bae53

correct state refresh

99fd6d1

correct ids and docs naming

e89162b

tombuildsstuff force-pushed the cm/split_sc_vuln branch from 58ef1ab to e89162b Compare March 23, 2022 20:39

tombuildsstuff added 2 commits March 23, 2022 22:07

securitycenter: removing the arc id

b9fab67

tombuildsstuff approved these changes Mar 23, 2022

View reviewed changes

...curitycenter/security_center_server_vulnerability_assessment_arc_virtual_machine_resource.go Outdated Show resolved Hide resolved

...curitycenter/security_center_server_vulnerability_assessment_arc_virtual_machine_resource.go Outdated Show resolved Hide resolved

tombuildsstuff requested a review from katbyte March 23, 2022 21:10

katbyte approved these changes Mar 23, 2022

View reviewed changes

docs: deprecating `azurerm_security_center_server_vulnerability_asses…

2672a32

…sment` in the upgrade guide

katbyte merged commit fbf0c92 into main Mar 23, 2022

katbyte deleted the cm/split_sc_vuln branch March 23, 2022 21:47

katbyte added a commit that referenced this pull request Mar 23, 2022

CHANGELOG.md for #15747

2f65480

github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_security_center_server_vulnerability_assessment` - deprecate in favour of `azurerm_security_center_vm_server_vulnerability_assessment` #15747

`azurerm_security_center_server_vulnerability_assessment` - deprecate in favour of `azurerm_security_center_vm_server_vulnerability_assessment` #15747

catriona-m commented Mar 8, 2022

katbyte Mar 10, 2022

catriona-m Mar 10, 2022

tombuildsstuff left a comment

tombuildsstuff Mar 10, 2022

tombuildsstuff Mar 10, 2022

tombuildsstuff Mar 10, 2022

tombuildsstuff Mar 10, 2022

tombuildsstuff Mar 10, 2022

tombuildsstuff Mar 10, 2022

tombuildsstuff Mar 10, 2022

tombuildsstuff Mar 10, 2022

tombuildsstuff Mar 10, 2022

tombuildsstuff Mar 10, 2022

tombuildsstuff left a comment

tombuildsstuff Mar 16, 2022

tombuildsstuff Mar 16, 2022

tombuildsstuff Mar 16, 2022

tombuildsstuff Mar 16, 2022

tombuildsstuff Mar 16, 2022

tombuildsstuff Mar 16, 2022

tombuildsstuff Mar 16, 2022

tombuildsstuff Mar 16, 2022

tombuildsstuff Mar 16, 2022

tombuildsstuff commented Mar 23, 2022

tombuildsstuff left a comment

katbyte left a comment

github-actions bot commented Mar 24, 2022

github-actions bot commented Apr 24, 2022

		"azurerm_security_center_vm_server_vulnerability_assessment": resourceVMServerVulnerabilityAssessment(),
		"azurerm_security_center_hybrid_vm_server_vulnerability_assessment": resourceHybridVMServerVulnerabilityAssessment(),

	"azurerm_security_center_server_vulnerability_assessment_hybrid_vm": resourceServerVulnerabilityAssessmentHybridVM(),
	"azurerm_security_center_server_vulnerability_arc_virtual_machine_assessment": resourceServerVulnerabilityAssessmentHybridVM(),

	See this [documentation](https://docs.microsoft.com/en-us/azure/security-center/security-center-get-started) to get started.
	See this [documentation](https://docs.microsoft.com/azure/security-center/security-center-get-started) to get started.


		The following arguments are supported:

		* `hybrid_machine_id` - (Required) The ID of the Azure ARC server to be monitored by vulnerability assessment. Changing this forces a new resource to be created.

azurerm_security_center_server_vulnerability_assessment - deprecate in favour of azurerm_security_center_vm_server_vulnerability_assessment #15747

azurerm_security_center_server_vulnerability_assessment - deprecate in favour of azurerm_security_center_vm_server_vulnerability_assessment #15747

Conversation

catriona-m commented Mar 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tombuildsstuff commented Mar 23, 2022

tombuildsstuff left a comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 24, 2022

github-actions bot commented Apr 24, 2022

`azurerm_security_center_server_vulnerability_assessment` - deprecate in favour of `azurerm_security_center_vm_server_vulnerability_assessment` #15747

`azurerm_security_center_server_vulnerability_assessment` - deprecate in favour of `azurerm_security_center_vm_server_vulnerability_assessment` #15747