-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_key_vault_key
- handling the parent Key Vault being deleted
#1535
Conversation
… deleted Also adds tests for the other resources
@@ -174,6 +174,11 @@ func resourceArmKeyVaultKeyRead(d *schema.ResourceData, meta interface{}) error | |||
|
|||
resp, err := client.GetKey(ctx, id.KeyVaultBaseUrl, id.Name, "") | |||
if err != nil { | |||
if utils.ResponseWasNotFound(resp.Response) { | |||
d.SetId("") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be great to log that we're removing the key from state because it wasn't found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
* api-management: Updating to include hashicorp#1565 resource/servicebus_subscription_rule: Fix the correlation_filter optional values (hashicorp#1565) Updating to include hashicorp#1563 resouce/app_insights: Allow different application_type deployments (hashicorp#1563) VMSS: changed sku property from a set to list Update CHANGELOG.md to include hashicorp#1552 Renamed azurerm_azuread_application.html.markdown to azuread_application.html.markdown New Data Source: `azurerm_azuread_application` VMSS: Updating the code samples to be valid. Fixes hashicorp#1539 (hashicorp#1549) Creation Data -> Creation Date (hashicorp#1548) Updating to include hashicorp#1546 Workaround upstream issue in creating azureEndpoints in traffic manager (hashicorp#1546) Cleanup after v1.9.0 release v1.9.0 Updating to include hashicorp#1269 New Resource: `azurerm_azuread_application` (hashicorp#1269) Remove tags validate in preConfig of TestAccAzureRMKeyVault_update (hashicorp#1534) Updating to include hashicorp#1535 `azurerm_key_vault_key` - handling the parent Key Vault being deleted (hashicorp#1535)
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Currently Key Vault Key's don't detect that the parent Key Vault has been deleted during the refresh, and so they fail:
Fixes #1240
Key Vault tests pass:
Key Vault Certificate tests pass:
Key Vault Key tests pass:
Key Vault Secret tests pass: