Upgrade sentinel API to 2021-09-01-preview

[magodo]

Upgrade sentinel API to 2021-09-01-preview.

Note that there is one breaking change in the azurerm_sentinel_alert_rule_scheduled resource, where the allowed enums of the entity_matching_method changed from [All, Custom, None] to [AnyAlert, Selected, AllEntities].

Related issues: #14244, #14973

[tombuildsstuff]

hi @magodo

Thanks for this PR.

Taking a look through as you've mentioned there's some breaking changes in this PR - what's the migration path for existing users?

Thanks!

[tombuildsstuff]

what's the migration path for users/resources here?

[magodo]

Just confirmed with the service team and verified in my local: the original enums All, Custom, None corresponds to the AllEntities, Selected and AnyAlert. If the user creats the alert rule using the old API version, and do a GET using the new one, the enums are returned in their new form.

[kaovd]

Reckon for any enums that dont do this could translate them and provide a warning to the user for a few versions - although if all old enums behave like this users will know to fix their configuration when their is idempotency

[magodo]

Good idea, I'll make the change.

[katbyte]

@magodo - we have some licensing issues:

------- Stdout: -------
=== RUN   TestAccAzureRMSentinelDataConnectorAzureAdvancedThreatProtection_basic
=== PAUSE TestAccAzureRMSentinelDataConnectorAzureAdvancedThreatProtection_basic
=== CONT  TestAccAzureRMSentinelDataConnectorAzureAdvancedThreatProtection_basic
    testcase.go:110: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating Data Connector: (Name "accTestDC-220128025125641996" / Workspace Name "acctestLAW-220128025125641996" / Resource Group "acctestRG-sentinel-220128025125641996"): securityinsight.DataConnectorsClient#CreateOrUpdate: Failure responding to request: StatusCode=401 -- Original Error: autorest/azure: Service returned an error. Status=401 Code="InvalidLicense" Message="License is invalid"
        
          with azurerm_sentinel_data_connector_azure_advanced_threat_protection.test,
          on terraform_plugin_test.tf line 33, in resource "azurerm_sentinel_data_connector_azure_advanced_threat_protection" "test":
          33: resource "azurerm_sentinel_data_connector_azure_advanced_threat_protection" "test" {
        
--- FAIL: TestAccAzureRMSentinelDataConnectorAzureAdvancedThreatProtection_basic (164.98s)
FAIL

Do you know how we can resolve this in our tenant?

[magodo]

@katbyte The license issue has been last for quite a while, I've ping you in the slack channel for the context of that issue. Personally, I don't have the knowledge about the license setup, since my account don't have that permission in the tenant.

[magodo]

@katbyte Is there any chance that we can get this PR merged? There are a couple of sentinel related new features pending on this PR.

[katbyte]

Thanks @magodo - LGTM 🏗️

[github-actions]

This functionality has been released in v2.99.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.