Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource health to azurerm_monitor_activity_log_alert #14917

Merged
merged 4 commits into from
Feb 16, 2022
Merged

Add resource health to azurerm_monitor_activity_log_alert #14917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29606ca
Add resource health to activity log alerts
tj-spyro Jan 12, 2022
4c895d2
Remove `_health` from argument names
tj-spyro Jan 13, 2022
d73bd12
Reworded documentation
tj-spyro Feb 3, 2022
7be6628
Fix failing test
tj-spyro Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
147 changes: 146 additions & 1 deletion internal/services/monitor/monitor_activity_log_alert_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,64 @@ func resourceMonitorActivityLogAlert() *pluginsdk.Resource {
ConflictsWith: []string{"criteria.0.recommendation_category", "criteria.0.recommendation_impact"},
},
//lintignore:XS003
"resource_health": {
Type: pluginsdk.TypeList,
Computed: true,
Optional: true,
Elem: &pluginsdk.Resource{
Schema: map[string]*pluginsdk.Schema{
"current": {
Type: pluginsdk.TypeSet,
Optional: true,
Elem: &pluginsdk.Schema{
Type: pluginsdk.TypeString,
ValidateFunc: validation.StringInSlice([]string{
"Available",
"Degraded",
"Unavailable",
"Unknown",
},
false,
),
},
Set: pluginsdk.HashString,
},
"previous": {
Type: pluginsdk.TypeSet,
Optional: true,
Elem: &pluginsdk.Schema{
Type: pluginsdk.TypeString,
ValidateFunc: validation.StringInSlice([]string{
"Available",
"Degraded",
"Unavailable",
"Unknown",
},
false,
),
},
Set: pluginsdk.HashString,
},
"reason": {
Type: pluginsdk.TypeSet,
Optional: true,
Elem: &pluginsdk.Schema{
Type: pluginsdk.TypeString,
ValidateFunc: validation.StringInSlice([]string{
"PlatformInitiated",
"UserInitiated",
"Unknown",
},
false,
),
},
Set: pluginsdk.HashString,
},
},
},
ConflictsWith: []string{"criteria.0.recommendation_category", "criteria.0.recommendation_impact", "criteria.0.status", "criteria.0.sub_status", "criteria.0.recommendation_impact", "criteria.0.resource_provider", "criteria.0.resource_type", "criteria.0.operation_name", "criteria.0.caller", "criteria.0.operation_name", "criteria.0.service_health"},
},
//lintignore:XS003
"service_health": {
Type: pluginsdk.TypeList,
Computed: true,
Expand Down Expand Up @@ -203,7 +261,7 @@ func resourceMonitorActivityLogAlert() *pluginsdk.Resource {
},
},
},
ConflictsWith: []string{"criteria.0.recommendation_category", "criteria.0.recommendation_impact", "criteria.0.status", "criteria.0.sub_status", "criteria.0.recommendation_impact", "criteria.0.resource_provider", "criteria.0.resource_type", "criteria.0.operation_name", "criteria.0.caller", "criteria.0.operation_name"},
ConflictsWith: []string{"criteria.0.recommendation_category", "criteria.0.recommendation_impact", "criteria.0.status", "criteria.0.sub_status", "criteria.0.recommendation_impact", "criteria.0.resource_provider", "criteria.0.resource_type", "criteria.0.operation_name", "criteria.0.caller", "criteria.0.operation_name", "criteria.0.resource_health"},
},
},
},
Expand Down Expand Up @@ -440,6 +498,10 @@ func expandMonitorActivityLogAlertCriteria(input []interface{}) *insights.AlertR
})
}

if resourceHealth := v["resource_health"].([]interface{}); len(resourceHealth) > 0 {
conditions = expandResourceHealth(resourceHealth, conditions)
}

if serviceHealth := v["service_health"].([]interface{}); len(serviceHealth) > 0 {
conditions = expandServiceHealth(serviceHealth, conditions)
}
Expand All @@ -449,6 +511,61 @@ func expandMonitorActivityLogAlertCriteria(input []interface{}) *insights.AlertR
}
}

func expandResourceHealth(resourceHealth []interface{}, conditions []insights.AlertRuleAnyOfOrLeafCondition) []insights.AlertRuleAnyOfOrLeafCondition {
for _, serviceItem := range resourceHealth {
if serviceItem == nil {
continue
}
vs := serviceItem.(map[string]interface{})

cv := vs["current"].(*pluginsdk.Set)
if len(cv.List()) > 0 {
ruleLeafCondition := make([]insights.AlertRuleLeafCondition, 0)
for _, e := range cv.List() {
event := e.(string)
ruleLeafCondition = append(ruleLeafCondition, insights.AlertRuleLeafCondition{
Field: utils.String("properties.currentHealthStatus"),
Equals: utils.String(event),
})
}
conditions = append(conditions, insights.AlertRuleAnyOfOrLeafCondition{
AnyOf: &ruleLeafCondition,
})
}

pv := vs["previous"].(*pluginsdk.Set)
if len(pv.List()) > 0 {
ruleLeafCondition := make([]insights.AlertRuleLeafCondition, 0)
for _, e := range pv.List() {
event := e.(string)
ruleLeafCondition = append(ruleLeafCondition, insights.AlertRuleLeafCondition{
Field: utils.String("properties.previousHealthStatus"),
Equals: utils.String(event),
})
}
conditions = append(conditions, insights.AlertRuleAnyOfOrLeafCondition{
AnyOf: &ruleLeafCondition,
})
}

rv := vs["reason"].(*pluginsdk.Set)
if len(rv.List()) > 0 {
ruleLeafCondition := make([]insights.AlertRuleLeafCondition, 0)
for _, e := range rv.List() {
event := e.(string)
ruleLeafCondition = append(ruleLeafCondition, insights.AlertRuleLeafCondition{
Field: utils.String("properties.cause"),
Equals: utils.String(event),
})
}
conditions = append(conditions, insights.AlertRuleAnyOfOrLeafCondition{
AnyOf: &ruleLeafCondition,
})
}
}
return conditions
}

func expandServiceHealth(serviceHealth []interface{}, conditions []insights.AlertRuleAnyOfOrLeafCondition) []insights.AlertRuleAnyOfOrLeafCondition {
for _, serviceItem := range serviceHealth {
if serviceItem == nil {
Expand Down Expand Up @@ -544,13 +661,41 @@ func flattenMonitorActivityLogAlertCriteria(input *insights.AlertRuleAllOfCondit
}
}

if result["category"] == "ResourceHealth" {
flattenMonitorActivityLogAlertResourceHealth(input, result)
}

if result["category"] == "ServiceHealth" {
flattenMonitorActivityLogAlertServiceHealth(input, result)
}

return []interface{}{result}
}

func flattenMonitorActivityLogAlertResourceHealth(input *insights.AlertRuleAllOfCondition, result map[string]interface{}) {
rhResult := make(map[string]interface{})
for _, condition := range *input.AllOf {
if condition.Field == nil && len(*condition.AnyOf) > 0 {
values := []string{}
for _, cond := range *condition.AnyOf {
if cond.Field != nil && cond.Equals != nil {
values = append(values, *cond.Equals)
}
switch strings.ToLower(*cond.Field) {
case "properties.currenthealthstatus":
rhResult["current"] = values
case "properties.previoushealthstatus":
rhResult["previous"] = values
case "properties.cause":
rhResult["reason"] = values
}
}
}
}

result["resource_health"] = []interface{}{rhResult}
}

func flattenMonitorActivityLogAlertServiceHealth(input *insights.AlertRuleAllOfCondition, result map[string]interface{}) {
shResult := make(map[string]interface{})
for _, condition := range *input.AllOf {
Expand Down
Loading