Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for azurerm_firewall.sku_tier #14907

Merged

Conversation

shu-ying789
Copy link
Contributor

sku

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have some test failures:

------- Stdout: -------
=== RUN   TestAccFirewallApplicationRuleCollection_noSource
=== PAUSE TestAccFirewallApplicationRuleCollection_noSource
=== CONT  TestAccFirewallApplicationRuleCollection_noSource
    testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting Azure Firewall Firewall: (Azure Firewall Name "acctestfirewall220112055842432854" / Resource Group "acctestRG-fw-220112055842432854") : network.AzureFirewallsClient#Delete: Failure sending request: StatusCode=415 -- Original Error: Code="UnsupportedMediaType" Message="The content media type '<null>' is not supported. Only 'application/json' is supported."
        
--- FAIL: TestAccFirewallApplicationRuleCollection_noSource (305.85s)
FAIL

@tombuildsstuff
Copy link
Contributor

The Firewall Delete API issue is being tracked in #14966 and I believe is an upstream regression, fwiw

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - the test failures are unrelated to this

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review January 17, 2022 12:16

dismissing since the API failure is unrelated

@tombuildsstuff tombuildsstuff added this to the v2.93.0 milestone Jan 17, 2022
@tombuildsstuff tombuildsstuff merged commit fb5b4b8 into hashicorp:main Jan 17, 2022
@github-actions
Copy link

This functionality has been released in v2.93.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants