-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_monitor_action_group: support for the event_hub_receiver
block
#14771
Conversation
* `event_hub_name` - (Required) The name of the specific Event Hub queue. | ||
* `event_hub_namespace` - (Required) The Event Hub namespace. | ||
* `subscription_id` - (Optional) The ID for the subscription containing this Event Hub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of 3 separate properties could we use the event_hub_namespace.id
and parse these out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @katbyte, I like the idea. To get a better understanding, you suggest that we just take the ID of the EventHub Namespace and then use the EventHub client to retrieve the rest of the required data within expandMonitorActionGroupEventHubReceiver
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I misunderstood you. You mean taking the resource id of the namespace directly and parse subscription id, event hub name and namespace from the id, right?
The issue is that the resource id of the namespace does not contain the name of the event hub.
This is an example resource id:
/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/group1/providers/Microsoft.EventHub/namespaces/namespace1
Hence, we would still need the event hub name, and the subscription id is optional anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ID of the actual eventhub within the namespace would work however:
/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/group1/providers/Microsoft.EventHub/namespaces/namespace1/eventhubs/hub1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @katbyte I added your suggestions, happy for any feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry my mistake i swapped hub and namespace in my mind 😅 perfect thanks
event_hub_receiver
block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dennis-menge - LGTM ⛵
This functionality has been released in v2.92.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes: #14374
Added EventHub Receiver Type for Monitor Action Group as it has gone GA on November 3rd
Since this feature was not supported by the Azure Go SDK until last week, I also had to bump the Azure SDK to v61.0.0
Acceptance Test output: