azurerm_mssql_database_vulnerability_assessment_rule_baseline: fix the resource is being replaced every new tf apply issue

[sinbai]

The purpose of this PR:

Fix Issue #14695. The issue is that the resource azurerm_mssql_database_vulnerability_assessment_rule_baseline is always created when the "terraform apply" runs every time, even if the tf config is not changed. The server_vulnerability_assessment_id property is ForceNew in terraform. So, when the value of the property is changed, the resource would be re-created. In this case, the root cause is that the DatabaseVulnerabilityAssessments API returns the VulnerabilityAssessmentName of id in uppercase, which changes the property value. So, I submitted this PR as a workaround for the issue. And I created an issue for Azure API to fix it completely. And this PR should be reverted after the API issue is fixed.

Test results:
PASS: TestAccMsSqlDatabaseVulnerabilityAssessmentRuleBaseline_basic (461.71s)
PASS: TestAccMsSqlDatabaseVulnerabilityAssessmentRuleBaseline_primary (550.76s)

[tombuildsstuff]

hey @sinbai

Thanks for this PR - apologies for the delayed review here.

I've taken a look through and it appears this data can come from the ID being provided, as such we can use that casing here which should solve this.

Thanks!

[tombuildsstuff]

since this is coming from the user input we can make this:

Suggested change

	vulnerabilityAssessmentId := parse.NewServerVulnerabilityAssessmentID(id.SubscriptionId, id.ResourceGroup, id.ServerName, "Default")
	vulnerabilityAssessmentId := parse.NewServerVulnerabilityAssessmentID(id.SubscriptionId, id.ResourceGroup, id.ServerName, id.DatabaseName, id.VulnerabilityAssessmentName)

which'll make it consistent with how this is handled above

[sinbai]

Thank you, Fixed.

[katbyte]

Thanks @sinbai - LGTM 🦀

[github-actions]

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.