-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure DNS CAA record support #1450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ranieuwe,
Thanks for the PR and congrats on your first contribution to Terraform. After review it LGTM.
Update CHANGELOG.md to include #1450
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR Fixes #890
Steps taken:
All DNS tests have been executed (testacc, test) and are successful.
Introduction of the 2017-10-01 API does also allow for extended ASCII sets for TXT records. Have not tested or implemented that yet.
First contribution to Terraform. Looking forward to your review!