Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r\iothub_endpoint_storage_container: Fix file_name_format Schema #14458

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Dec 3, 2021

file_name_format should not have default value set to false, instead it should have a ValidateFunc same as the nested endpoint property in iothub.

"file_name_format": {
Type: pluginsdk.TypeString,
Optional: true,
ValidateFunc: iothubValidate.FileNameFormat,
},

Test result:
$ TF_ACC=1 go test -v ./internal/services/iothub -run=TestAccIotHubEndpointStorageContainer_ -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccIotHubEndpointStorageContainer_basic
=== PAUSE TestAccIotHubEndpointStorageContainer_basic
=== RUN TestAccIotHubEndpointStorageContainer_requiresImport
=== PAUSE TestAccIotHubEndpointStorageContainer_requiresImport
=== CONT TestAccIotHubEndpointStorageContainer_basic
=== CONT TestAccIotHubEndpointStorageContainer_requiresImport
--- PASS: TestAccIotHubEndpointStorageContainer_basic (556.70s)
--- PASS: TestAccIotHubEndpointStorageContainer_requiresImport (597.94s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/iothub 598.822s

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @myc2h6o, LGTM 👍🏼

@stephybun stephybun merged commit 62d870b into hashicorp:main Dec 3, 2021
@github-actions github-actions bot added this to the v2.89.0 milestone Dec 3, 2021
stephybun added a commit that referenced this pull request Dec 3, 2021
@myc2h6o myc2h6o deleted the iot_storage_fileformat branch December 6, 2021 02:24
@github-actions
Copy link

This functionality has been released in v2.89.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants