Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_elastic_pool - Support for Fsv2 family #14250

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Nov 18, 2021

Fixes #14203
Extends #13973

Acceptance Tests

TF_ACC=1 go test -v ./internal/services/mssql -run=TestAccMsSqlElasticPool_fsv2FamilyVCore -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMsSqlElasticPool_fsv2FamilyVCore
=== PAUSE TestAccMsSqlElasticPool_fsv2FamilyVCore
=== CONT  TestAccMsSqlElasticPool_fsv2FamilyVCore
--- PASS: TestAccMsSqlElasticPool_fsv2FamilyVCore (553.34s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mssql   556.243s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - LGTM 🏗️

@katbyte katbyte merged commit 3539be0 into hashicorp:main Nov 18, 2021
@github-actions github-actions bot added this to the v2.86.0 milestone Nov 18, 2021
katbyte added a commit that referenced this pull request Nov 18, 2021
@github-actions
Copy link

This functionality has been released in v2.86.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Fsv2 family to azurerm_mssql_elasticpool sku
2 participants