Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade autorest to 10.11.4 and Azure SDK to 17.4.0 #1418

Merged
merged 3 commits into from
Jun 24, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jun 20, 2018

autorest 10.8.1 -> 10.11.2
Azure SDK 16.2.1 -> 17.?

Verified

This commit was signed with the committer’s verified signature.
@katbyte katbyte added this to the 1.8.0 milestone Jun 20, 2018
@katbyte
Copy link
Collaborator Author

katbyte commented Jun 20, 2018

So far the AppService resource now panics, opened an SDK issue with details.

@tombuildsstuff
Copy link
Contributor

A new version of autorest was released yesterday which should unblock this 👍

@tombuildsstuff tombuildsstuff changed the title Upgrade autorest to 10.11.2 and Aure SDK to 17.3.1 Upgrade autorest to 10.11.2 and Azure SDK to 17.3.1 Jun 22, 2018

Verified

This commit was signed with the committer’s verified signature.
@katbyte katbyte changed the title Upgrade autorest to 10.11.2 and Azure SDK to 17.3.1 Upgrade autorest to 10.11.4 and Azure SDK to 17.4.0 Jun 22, 2018
@katbyte
Copy link
Collaborator Author

katbyte commented Jun 23, 2018

Merged in the new autorest, ran all tests and nothing is standing out so this should be ready to review

@katbyte katbyte requested a review from tombuildsstuff June 23, 2018 04:23
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 828291d into master Jun 24, 2018
@tombuildsstuff tombuildsstuff deleted the vender-autorest10.11_sdk17.03 branch June 24, 2018 12:44
tombuildsstuff added a commit that referenced this pull request Jun 24, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants