Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the extendedLocation property #14159

Closed
wants to merge 13 commits into from

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Nov 12, 2021

This PR is to support extendedLocation (aka: EdgeZone). It allows customers to take advantage of more granular locations, which means it offers Azure capacity close to the customer to address the low latency and high throughput requirements and Data Residency requirements of the applications.

--- PASS: TestAccLinuxVirtualMachine_otherExtendedLocation (660.57s)
--- PASS: TestAccLinuxVirtualMachineScaleSet_otherExtendedLocation (667.46s)
--- PASS: TestAccWindowsVirtualMachine_otherExtendedLocation (607.88s)
--- PASS: TestAccWindowsVirtualMachineScaleSet_otherExtendedLocation (621.62s)
--- PASS: TestAccAzureRMLoadBalancer_extendedLocation (443.23s)
--- PASS: TestAccManagedDisk_extendedLocation (362.24s)
--- PASS: TestAccNetworkInterface_extendedLocation (471.21s)
--- PASS: TestAccPublicIpStatic_extendedLocation (605.98s)
--- PASS: TestAccVirtualNetwork_extendedLocation (401.62s)
--- PASS: TestAccStorageAccount_extendedLocation (2512.72s)
--- PASS: TestAccVirtualNetworkGateway_extendedLocation (2976.97s)

disk
lb
linuxvm1
linuxvm2
linuxvm3
linuxvm4
linuxvm5
linuxvmss1
linuxvmss2
linuxvmss3
linuxvmss4
linuxvmss6
linuxvmss7
linuxvmss8
linuxvmss9
linuxvmss10
nic
pip_1
pip_2
storage1
storage2
vnet
vnetgateway1
vnetgateway2
windowsvm1
windowsvm2
windowsvm3
windowsvm4
windowsvm5
windowsvmss1
windowsvmss2
windowsvmss3
windowsvmss4
windowsvmss5
windowsvmss6
windowsvmss7
windowsvmss8
windowsvmss9
windowsvmss10

@tombuildsstuff
Copy link
Contributor

@neil-yechenwei apologies for the delay reviewing this one - can you rebase this PR?

@neil-yechenwei
Copy link
Contributor Author

@tombuildsstuff , I've updated PR. Please take another look. Thanks.

@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented Jan 20, 2022

There's an internal thread tracking clarification to the design of this resource - as Extended Location is a struct here we want to confirm the design is correct.

@tombuildsstuff
Copy link
Contributor

Also dependent on hashicorp/go-azure-helpers#97

@tombuildsstuff
Copy link
Contributor

@DwayneNeed I can't reply to your thread inline for some reason - but yes I'd agree that Extended Locations would make a reasonable Data Source here

@tombuildsstuff
Copy link
Contributor

hi @neil-yechenwei

I've spent some time digging into this PR this week and whilst this is off to a good start unfortunately we need to take a different direction here.

Whilst I initially started out trying to fix this PR up, since there's a non-trivial number of changes needed it ended up being quicker to take a fresh branch and make these to ensure these are all up to date, rather than trying to retroactively fix this PR.

As such I hope you don't mind but I'm going to close this PR in favour of #15890 which switches to using commonschema types for these, which'll allow us to support this functionality.

Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants