-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the extendedLocation
property
#14159
Conversation
@neil-yechenwei apologies for the delay reviewing this one - can you rebase this PR? |
@tombuildsstuff , I've updated PR. Please take another look. Thanks. |
There's an internal thread tracking clarification to the design of this resource - as Extended Location is a struct here we want to confirm the design is correct. |
Also dependent on hashicorp/go-azure-helpers#97 |
@DwayneNeed I can't reply to your thread inline for some reason - but yes I'd agree that Extended Locations would make a reasonable Data Source here |
I've spent some time digging into this PR this week and whilst this is off to a good start unfortunately we need to take a different direction here. Whilst I initially started out trying to fix this PR up, since there's a non-trivial number of changes needed it ended up being quicker to take a fresh branch and make these to ensure these are all up to date, rather than trying to retroactively fix this PR. As such I hope you don't mind but I'm going to close this PR in favour of #15890 which switches to using Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR is to support
extendedLocation
(aka: EdgeZone). It allows customers to take advantage of more granular locations, which means it offers Azure capacity close to the customer to address the low latency and high throughput requirements and Data Residency requirements of the applications.--- PASS: TestAccLinuxVirtualMachine_otherExtendedLocation (660.57s)
--- PASS: TestAccLinuxVirtualMachineScaleSet_otherExtendedLocation (667.46s)
--- PASS: TestAccWindowsVirtualMachine_otherExtendedLocation (607.88s)
--- PASS: TestAccWindowsVirtualMachineScaleSet_otherExtendedLocation (621.62s)
--- PASS: TestAccAzureRMLoadBalancer_extendedLocation (443.23s)
--- PASS: TestAccManagedDisk_extendedLocation (362.24s)
--- PASS: TestAccNetworkInterface_extendedLocation (471.21s)
--- PASS: TestAccPublicIpStatic_extendedLocation (605.98s)
--- PASS: TestAccVirtualNetwork_extendedLocation (401.62s)
--- PASS: TestAccStorageAccount_extendedLocation (2512.72s)
--- PASS: TestAccVirtualNetworkGateway_extendedLocation (2976.97s)