VirtualNetworkGateway Additional Testcases

[lrxtom2]

TestAccAzureRMVirtualNetworkGateway_standard
TestAccAzureRMVirtualNetworkGateway_vpnGw2
TestAccAzureRMVirtualNetworkGateway_vpnGw3

[tombuildsstuff]

hey @lrxtom2

Thanks for this PR - I've taken a look through and left a few minor comments inline - but this otherwise looks good to me. If we can resolve those issues & fix the merge conflict then we should be able to run the tests and merge this :)

Thanks!

[tombuildsstuff]

"azurerm_virtual_network_gateway.test" -> resourceName

[tombuildsstuff]

"azurerm_virtual_network_gateway.test" -> resourceName

[tombuildsstuff]

"azurerm_virtual_network_gateway.test" -> resourceName

[tombuildsstuff]

hey @lrxtom2

Thanks for fixing the merge conflicts; if we can fix the build failure then this should be good to merge:

$ make test
==> Checking that code complies with gofmt requirements...
gofmt needs running on the following files:
./azurerm/resource_arm_virtual_network_gateway_test.go
You can use the command: `make fmt` to reformat code.
make: *** [fmtcheck] Error 1

Thanks!

[lrxtom2]

Thanks for @tombuildsstuff
I will pay attention to that next time.

[tombuildsstuff]

thanks for fixing those issues, this now LGTM 👍

[tombuildsstuff]

Tests pass, ignoring an existing test failure (which is fixed in #1431):

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!