Added support for patch_mode in resource_linux_virtual_machine.

[atombrella]

Fixes #13257

I have not yet run the acceptance tests. I have an Azure account, but it's a bit inactive. I thought this might be a good occasion to learn a bit more about Azure :)

[catriona-m]

Hi @atombrella, thanks for submitting this! I ran the tests and can see the added test is currently failing:

------- Stdout: -------
=== RUN   TestAccLinuxVirtualMachine_linuxPatchModeSetting
=== PAUSE TestAccLinuxVirtualMachine_linuxPatchModeSetting
=== CONT  TestAccLinuxVirtualMachine_linuxPatchModeSetting
testcase.go:108: Step 1/2 error: Error running apply: exit status 1
Error: At least one `admin_ssh_key` must be specified when `disable_password_authentication` is set to `true`
with azurerm_linux_virtual_machine.test,
on terraform_plugin_test.tf line 43, in resource "azurerm_linux_virtual_machine" "test":
43: resource "azurerm_linux_virtual_machine" "test" {
--- FAIL: TestAccLinuxVirtualMachine_linuxPatchModeSetting (207.81s)
FAIL

It looks like there's a linting error that needs correcting too.

It would also be good if we could include this property in an update test to confirm that works as well.

[atombrella]

@catriona-m Thanks for the review :) I'll try to push a "green version" of this during the weekend. Hopefully having a single test for the verification and update is fine, or do you prefer two separate tests?

[catriona-m]

@catriona-m Thanks for the review :) I'll try to push a "green version" of this during the weekend. Hopefully having a single test for the verification and update is fine, or do you prefer two separate tests?

@atombrella thanks for updating this, the new changes look good, only this test is still failing:

------- Stdout: -------
=== RUN   TestAccLinuxVirtualMachine_linuxPatchModeSetting
=== PAUSE TestAccLinuxVirtualMachine_linuxPatchModeSetting
=== CONT  TestAccLinuxVirtualMachine_linuxPatchModeSetting
testcase.go:109: Step 1/3 error: Error running apply: exit status 1
Error: At least one `admin_ssh_key` must be specified when `disable_password_authentication` is set to `true`
with azurerm_linux_virtual_machine.test,
on terraform_plugin_test.tf line 43, in resource "azurerm_linux_virtual_machine" "test":
43: resource "azurerm_linux_virtual_machine" "test" {
--- FAIL: TestAccLinuxVirtualMachine_linuxPatchModeSetting (255.06s)
FAIL

You may need to add an admin_ssh_key in the test data to get this working eg -

terraform-provider-azurerm/internal/services/compute/linux_virtual_machine_resource_auth_test.go

Line 155 in 59a5883

admin_ssh_key {

[atombrella]

@catriona-m Thanks for the review :) I'll try to push a "green version" of this during the weekend. Hopefully having a single test for the verification and update is fine, or do you prefer two separate tests?

@atombrella thanks for updating this, the new changes look good, only this test is still failing:

------- Stdout: -------
=== RUN   TestAccLinuxVirtualMachine_linuxPatchModeSetting
=== PAUSE TestAccLinuxVirtualMachine_linuxPatchModeSetting
=== CONT  TestAccLinuxVirtualMachine_linuxPatchModeSetting
testcase.go:109: Step 1/3 error: Error running apply: exit status 1
Error: At least one `admin_ssh_key` must be specified when `disable_password_authentication` is set to `true`
with azurerm_linux_virtual_machine.test,
on terraform_plugin_test.tf line 43, in resource "azurerm_linux_virtual_machine" "test":
43: resource "azurerm_linux_virtual_machine" "test" {
--- FAIL: TestAccLinuxVirtualMachine_linuxPatchModeSetting (255.06s)
FAIL

You may need to add an admin_ssh_key in the test data to get this working eg -

terraform-provider-azurerm/internal/services/compute/linux_virtual_machine_resource_auth_test.go

Line 155 in 59a5883

admin_ssh_key {

Done. Thanks :)

[katbyte]

Thanks @atombrella - LGTM 💯

[atombrella]

Good :) @katbyte I think probably I forgot to add something to read the new property under the read-function.

[github-actions]

This functionality has been released in v2.84.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.