Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement to azurerm_servicebus_namespace_network_rule_set: Support 'allow trusted services' #13853

Merged
merged 5 commits into from
Oct 25, 2021

Conversation

dylanmorley
Copy link
Contributor

@dylanmorley dylanmorley commented Oct 22, 2021

Per #9740, supporting allow_trusted_services on service bus namespace network restrictions

 TF_ACC=1 go test -v ./internal/services/servicebus -run=TestAccServiceB usNamespaceNetworkRule_ -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccServiceBusNamespaceNetworkRule_basic
=== PAUSE TestAccServiceBusNamespaceNetworkRule_basic
=== RUN   TestAccServiceBusNamespaceNetworkRule_complete
=== PAUSE TestAccServiceBusNamespaceNetworkRule_complete
=== RUN   TestAccServiceBusNamespaceNetworkRule_update
=== PAUSE TestAccServiceBusNamespaceNetworkRule_update
=== RUN   TestAccServiceBusNamespaceNetworkRule_requiresImport
=== PAUSE TestAccServiceBusNamespaceNetworkRule_requiresImport
=== CONT  TestAccServiceBusNamespaceNetworkRule_basic
=== CONT  TestAccServiceBusNamespaceNetworkRule_requiresImport
=== CONT  TestAccServiceBusNamespaceNetworkRule_update
=== CONT  TestAccServiceBusNamespaceNetworkRule_complete
--- PASS: TestAccServiceBusNamespaceNetworkRule_basic (424.04s)
--- PASS: TestAccServiceBusNamespaceNetworkRule_update (631.10s)
--- PASS: TestAccServiceBusNamespaceNetworkRule_requiresImport (648.90s)
--- PASS: TestAccServiceBusNamespaceNetworkRule_complete (718.80s)
PASS

@dylanmorley dylanmorley marked this pull request as ready for review October 22, 2021 12:18
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dylanmorley - overall this looks good aside from one comment on the property name, once thats renamed this should be good to merge!

@dylanmorley dylanmorley requested a review from katbyte October 25, 2021 20:31
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dylanmorley - LGTM 🏗️

@katbyte katbyte added this to the v2.83.0 milestone Oct 25, 2021
@katbyte katbyte merged commit 296e468 into hashicorp:main Oct 25, 2021
katbyte added a commit that referenced this pull request Oct 25, 2021
@github-actions
Copy link

This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants