Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_storage_account encryption now on by default #1380

Merged
merged 1 commit into from
Jun 12, 2018
Merged

azurerm_storage_account encryption now on by default #1380

merged 1 commit into from
Jun 12, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jun 12, 2018

Fixes #1028

@katbyte katbyte added this to the 1.7.0 milestone Jun 12, 2018
@katbyte katbyte mentioned this pull request Jun 12, 2018
Closed
@katbyte katbyte force-pushed the b-storage_account-encryption_default branch from 272819f to 5bc83d0 Compare June 12, 2018 06:39
@katbyte katbyte requested a review from a team June 12, 2018 06:48
mbfrahry
mbfrahry requested changes Jun 12, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can set the Default: true. But it looks like the real issue is not checking if the value has been set in the config here

@katbyte katbyte force-pushed the b-storage_account-encryption_default branch from 5bc83d0 to 0667879 Compare June 12, 2018 15:08
@katbyte katbyte force-pushed the b-storage_account-encryption_default branch from 0667879 to 14e3277 Compare June 12, 2018 15:14
mbfrahry
mbfrahry approved these changes Jun 12, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the fmting issue

azurerm/resource_arm_storage_account.go Outdated
}},
},
File: &storage.EncryptionService{
Enabled: utils.Bool(enableFileEncryption),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fmting issue here

@katbyte katbyte merged commit ada9706 into master Jun 12, 2018
@katbyte katbyte deleted the b-storage_account-encryption_default branch June 12, 2018 15:19
katbyte added a commit that referenced this pull request Jun 12, 2018
@katbyte
Update CHANGELOG.md to include #1380
0fc3bf3
@katbyte katbyte mentioned this pull request Jun 12, 2018
Closed
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
enhancement service/storage
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Default for undefined booleans without default (azurerm_storage_account/enable_blob_encryption)
2 participants
@katbyte @mbfrahry