azurerm_subnet_resource - Lock virtual network and subnet on update

[owenfarrell]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Summary

This pull request locks the subnet resource and associated virtual network when updating subnets to prevent conflicting, concurrent operations.

Fixes: #13564

Output from acceptance testing:

$ make acctests SERVICE='network' TESTARGS='-run="^TestAccSubnet_"'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/network -run="^TestAccSubnet_" -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccSubnet_basic
=== PAUSE TestAccSubnet_basic
=== RUN   TestAccSubnet_basic_addressPrefixes
=== PAUSE TestAccSubnet_basic_addressPrefixes
=== RUN   TestAccSubnet_complete_addressPrefixes
=== PAUSE TestAccSubnet_complete_addressPrefixes
=== RUN   TestAccSubnet_update_addressPrefixes
=== PAUSE TestAccSubnet_update_addressPrefixes
=== RUN   TestAccSubnet_requiresImport
=== PAUSE TestAccSubnet_requiresImport
=== RUN   TestAccSubnet_disappears
=== PAUSE TestAccSubnet_disappears
=== RUN   TestAccSubnet_delegation
=== PAUSE TestAccSubnet_delegation
=== RUN   TestAccSubnet_enforcePrivateLinkEndpointNetworkPolicies
=== PAUSE TestAccSubnet_enforcePrivateLinkEndpointNetworkPolicies
=== RUN   TestAccSubnet_enforcePrivateLinkServiceNetworkPolicies
=== PAUSE TestAccSubnet_enforcePrivateLinkServiceNetworkPolicies
=== RUN   TestAccSubnet_serviceEndpoints
=== PAUSE TestAccSubnet_serviceEndpoints
=== RUN   TestAccSubnet_serviceEndpointPolicy
=== PAUSE TestAccSubnet_serviceEndpointPolicy
=== RUN   TestAccSubnet_updateAddressPrefix
=== PAUSE TestAccSubnet_updateAddressPrefix
=== CONT  TestAccSubnet_basic
=== CONT  TestAccSubnet_delegation
=== CONT  TestAccSubnet_update_addressPrefixes
=== CONT  TestAccSubnet_serviceEndpoints
=== CONT  TestAccSubnet_enforcePrivateLinkEndpointNetworkPolicies
=== CONT  TestAccSubnet_enforcePrivateLinkServiceNetworkPolicies
=== CONT  TestAccSubnet_serviceEndpointPolicy
=== CONT  TestAccSubnet_complete_addressPrefixes
=== CONT  TestAccSubnet_updateAddressPrefix
--- PASS: TestAccSubnet_basic (202.03s)
--- PASS: TestAccSubnet_complete_addressPrefixes (374.71s)
=== CONT  TestAccSubnet_basic_addressPrefixes
--- PASS: TestAccSubnet_serviceEndpointPolicy (415.83s)
=== CONT  TestAccSubnet_disappears
--- PASS: TestAccSubnet_enforcePrivateLinkEndpointNetworkPolicies (473.57s)
=== CONT  TestAccSubnet_requiresImport
--- PASS: TestAccSubnet_update_addressPrefixes (475.50s)
--- PASS: TestAccSubnet_enforcePrivateLinkServiceNetworkPolicies (488.09s)
--- PASS: TestAccSubnet_serviceEndpoints (522.45s)
--- PASS: TestAccSubnet_updateAddressPrefix (368.98s)
--- PASS: TestAccSubnet_disappears (157.32s)
--- PASS: TestAccSubnet_basic_addressPrefixes (222.55s)
--- PASS: TestAccSubnet_delegation (615.58s)
--- PASS: TestAccSubnet_requiresImport (172.97s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       649.314s

[katbyte]

Thanks for fixing another one of these @owenfarrell! LGTM 🏗️

[github-actions]

This functionality has been released in v2.81.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.