-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_function_app & azurerm_app_service - support for vnet_route_all_enabled #13310
azurerm_function_app & azurerm_app_service - support for vnet_route_all_enabled #13310
Conversation
I'm waiting for this so I can start deploying my function apps with terraform. Thanks for getting it done! |
This should also be added to the azurerm_app_service resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @henrymcconville - Thanks for this, it looks good, if you can resolve the conflicts I'll run it through tests and get it approved / merged.
Thanks @jackofallops! Conflicts resolved and acc tests are still passing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @henrymcconville - LGTM now 🙌
This functionality has been released in v2.78.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #13259, inspired by #13073
Acceptance Tests: