-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synapse Workspace Activation with CMK #13179
Synapse Workspace Activation with CMK #13179
Conversation
729710d
to
72c2e93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr @MoAhuja - looks like we have some test failures to fix:
------- Stdout: -------
=== RUN TestAccSynapseWorkspace_azdo
=== PAUSE TestAccSynapseWorkspace_azdo
=== CONT TestAccSynapseWorkspace_azdo
testcase.go:88: Step 1/1 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# azurerm_synapse_workspace.test will be updated in-place
~ resource "azurerm_synapse_workspace" "test" {
+ customer_managed_key_name = "cmk"
id = "/subscriptions/*******/resourceGroups/acctestRG-synapse-210831222712997048/providers/Microsoft.Synapse/workspaces/acctestsw210831222712997048"
name = "acctestsw210831222712997048"
# (11 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccSynapseWorkspace_azdo (741.82s)
FAIL
@katbyte Thanks for the review. I've modified the synapse_workspace resource's property structure to bundle up key_name and key_versionless_id into a new type. This seemed like the only way to support a model where key_name could be optional and defaulted to "cmk" while making sure it's only ever used if key_versionless_id is set. Called this out here because this is breaking change from the previous version of the synapse workspace resource type and I'm not sure how those typically get handled as part of provider releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MoAhuja - LGTM 🏗️
54ddc77
to
83ea742
Compare
This functionality has been released in v2.77.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes: #12348