Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_private_dns_a_record - fix regression in name validation and add max recordset limit validation #13093

Merged
merged 2 commits into from
Aug 23, 2021
+3 −47
Merged

azurerm_private_dns_a_record - fix regression in name validation and add max recordset limit validation #13093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97f1c5b
revert a-name validation and fix max recordset limit
jackofallops Aug 23, 2021
b0dfcda
remove unused validation
jackofallops Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/services/privatedns/private_dns_a_record_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import (
"github.com/Azure/azure-sdk-for-go/services/privatedns/mgmt/2018-09-01/privatedns"
"github.com/hashicorp/terraform-provider-azurerm/helpers/azure"
"github.com/hashicorp/terraform-provider-azurerm/helpers/tf"
"github.com/hashicorp/terraform-provider-azurerm/helpers/validate"
"github.com/hashicorp/terraform-provider-azurerm/internal/clients"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/privatedns/parse"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/privatedns/validate"
"github.com/hashicorp/terraform-provider-azurerm/internal/tags"
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk"
"github.com/hashicorp/terraform-provider-azurerm/internal/timeouts"
Expand Down Expand Up @@ -40,7 +40,7 @@ func resourcePrivateDnsARecord() *pluginsdk.Resource {
Required: true,
ForceNew: true,
// lower-cased due to the broken API https://github.com/Azure/azure-rest-api-specs/issues/6641
ValidateFunc: validate.PrivateDnsARecordName,
ValidateFunc: validate.LowerCasedString,
},

// TODO: make this case sensitive once the API's fixed https://github.com/Azure/azure-rest-api-specs/issues/6641
Expand All @@ -54,6 +54,7 @@ func resourcePrivateDnsARecord() *pluginsdk.Resource {
"records": {
Type: pluginsdk.TypeSet,
Required: true,
MaxItems: 20,
Elem: &pluginsdk.Schema{Type: pluginsdk.TypeString},
Set: pluginsdk.HashString,
},
Expand Down
18 changes: 0 additions & 18 deletions internal/services/privatedns/validate/private_dns_a_record_name.go
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions internal/services/privatedns/validate/private_dns_a_record_name_test.go
View file
Open in desktop

This file was deleted.