Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_private_dns_a_record_resource - currently validate the name property by allowing @s #13042

Merged
merged 5 commits into from
Aug 19, 2021

Conversation

stephybun
Copy link
Member

Fixes #12406

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thought about refactoring this but this otherwise LGTM 👍

helpers/validate/strings.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/S and removed size/XS labels Aug 19, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - LGTM now 🏗️

@katbyte katbyte changed the title update str validation for at sign azurerm_private_dns_a_record_resource - currently validate the name property by allowing @s Aug 19, 2021
@katbyte katbyte merged commit 92f0a70 into main Aug 19, 2021
@katbyte katbyte deleted the b/update-str-validation branch August 19, 2021 19:01
katbyte added a commit that referenced this pull request Aug 19, 2021
@github-actions
Copy link

This functionality has been released in v2.73.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@calloes
Copy link

calloes commented Aug 24, 2021

Why is this changed ? apex dns records are valid in private dns zones. Our existing code now fails.

Internal DNS zone can have a valid root record represented by @

�[31m
�[1m�[31mError: �[0m�[0m�[1m"name" cannot contain @�[0m

�[0m on .terraform/modules/private_dns/main.tf line 7, in resource "azurerm_private_dns_a_record" "zone_root_a_record":
7: name = �[4m"@"�[0m
�[0m
�[0m�[0m

@stephybun
Copy link
Member Author

Hello @calloes, yep you are right. We've reverted the validation on name that's causing your code to fail and added validation on the number of allowed records in this PR #13093 which will be released in v2.74.0 on Thursday.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private DNS: no error while create A record with more than 20 records
4 participants