Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting workspace mode for application_insights_resource #12818

Merged
merged 24 commits into from
Aug 5, 2021
Merged

Supporting workspace mode for application_insights_resource #12818

merged 24 commits into from
Aug 5, 2021

Conversation

dylanmorley
Copy link
Contributor

As per issue #7667, updating the application_insights_resource to enable support of workspace mode, available with updated package 2020-02-02 in the Go SDK at v56.0.

  • Updated the insights API from 2015-05-01 to 2020-02-02
  • Fixed upgrade issues (enum changes )
  • Supporting workspace ID as an optional parameter when creating AI resources
  • Added workspace_id to data source resource
  • Documentation updates

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dylanmorley - aside from one comment this LGTM 🍕

website/docs/r/application_insights.html.markdown Outdated Show resolved Hide resolved
@katbyte katbyte added this to the v2.71.0 milestone Aug 4, 2021
@katbyte katbyte merged commit 0937cf0 into hashicorp:master Aug 5, 2021
katbyte added a commit that referenced this pull request Aug 5, 2021
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants