Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synapse: embedding a Track1 Data Plane SDK #12663

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jul 20, 2021

This PR embeds an Azure SDK for Go Track1 Data Plane SDK for Azure Synapse, so that those Data Plane resources can be built out. This client can be built as such:

func (client Client) Workspaces(workspaceName, synapseEndpointSuffix string) (*artifacts.WorkspaceClient, error) {
       if client.synapseAuthorizer == nil {
               return nil, fmt.Errorf("Synapse is not supported in this Azure Environment")
       }
       endpoint := buildEndpoint(workspaceName, synapseEndpointSuffix)
       workspacesClient := artifacts.NewWorkspaceClient(endpoint)
       workspacesClient.Client.Authorizer = client.synapseAuthorizer
       return &workspacesClient, nil
}

But notably the Data Plane API requires that a firewall rule be added for the IP address being used - as such this will either need to be a prerequisite, or added/removed dynamically - neither's great, but I'll leave that for the implementer of these data plane resources to work out.

Generated based on this upstream Swagger PR: Azure/azure-rest-api-specs#15263 - with one minor change to remove some incorrectly output "": autorest.Encode("path"), (since these are unnecessary)

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 6f17d21 into master Jul 20, 2021
@tombuildsstuff tombuildsstuff deleted the f/synapse-data-plane-track1-sdk branch July 20, 2021 09:45
@tombuildsstuff tombuildsstuff added this to the v2.69.0 milestone Jul 20, 2021
@github-actions
Copy link

This functionality has been released in v2.69.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants