Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9785 - prepare_encryption and infrastructure_encryption_enabled #12310

Closed
wants to merge 4 commits into from
Closed

Conversation

istairbn
Copy link
Contributor

Initial groundwork for completion of #9785

Two booleans missing from custom paramters: PrepareEncryption (turning on the managed identity) and RequireInfrastructureEncryption. infrastructure_encryption_enabled seemed to be the common term used elsewhere in the provider.

@istairbn
Copy link
Contributor Author

@WodansSon - just seen you're doing a massive API upgrade. Is this likely to become redundant?

CHANGELOG.md Outdated
@@ -7,6 +7,7 @@ ENHANCEMENTS:
* dependencies: updating to `v0.11.19` of `github.com/Azure/go-autorest/autorest` [GH-12209]
* dependencies: updating to `v0.9.14` of `github.com/Azure/go-autorest/autorest/adal` [GH-12209]
* dependencies: updating the embedded SDK for Eventhub Namespaces to use API Version `2021-01-01-preview` [GH-12290]
* `azurerm_databricks_workspace` - support for `infrastructure_encryption_enabled` and `prepare_encryption` ([#9785](https://github.com/terraform-providers/terraform-provider-azurerm/issues/9785))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @istairbn - Could you remove this from the PR please? The changelog is updated by maintainers at the point PR's are merged so they correctly reflect releases.
Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackofallops my bad - makes sense.
PR updated to strike the CHANGELOG changes

@jackofallops jackofallops modified the milestones: v2.66.0, v2.67.0 Jul 2, 2021
@jackofallops
Copy link
Member

Hi @istairbn - I think this change is covered by #12331 which, while opened later, also includes the customer managed key part of the requirement also, so I thank you for your efforts, but I'm going to close this in favour of that one.

@github-actions
Copy link

github-actions bot commented Jul 9, 2021

This functionality has been released in v2.67.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 9, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants