Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove acr validator from scopemaps #11784

Merged
merged 2 commits into from
May 20, 2021

Conversation

LP0101
Copy link
Contributor

@LP0101 LP0101 commented May 19, 2021

Remove incorrect validator from scopemaps, as mentioned in #11783

@ghost ghost added the size/XS label May 19, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @LP0101

Thanks for this PR.

Taking a look through whilst this is one approach to solving the issue - removing this validation makes it possible for folks to specify empty (or incorrect) values, which can cause ambiguous errors in the API - as such rather than removing this could we add a new validator covering the Container Registry Scope instead?

Thanks!

ValidateFunc: validate.ContainerRegistryName,
Type: schema.TypeString,
Required: true,
ForceNew: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than removing this, can we add a validator which includes the correct values here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, added in a new validator & tests for scope maps

@ghost ghost added size/M and removed size/XS labels May 19, 2021
@katbyte katbyte added this to the v2.60.0 milestone May 20, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LP0101 - LGTM now 🚀

@ghost
Copy link

ghost commented May 21, 2021

This has been released in version 2.60.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.60.0"
}
# ... other configuration ...

favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
Remove incorrect validator from scopemaps, as mentioned in hashicorp#11783
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants