-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove acr validator from scopemaps #11784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @LP0101
Thanks for this PR.
Taking a look through whilst this is one approach to solving the issue - removing this validation makes it possible for folks to specify empty (or incorrect) values, which can cause ambiguous errors in the API - as such rather than removing this could we add a new validator covering the Container Registry Scope instead?
Thanks!
ValidateFunc: validate.ContainerRegistryName, | ||
Type: schema.TypeString, | ||
Required: true, | ||
ForceNew: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than removing this, can we add a validator which includes the correct values here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, added in a new validator & tests for scope maps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LP0101 - LGTM now 🚀
This has been released in version 2.60.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.60.0"
}
# ... other configuration ... |
Remove incorrect validator from scopemaps, as mentioned in hashicorp#11783
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Remove incorrect validator from scopemaps, as mentioned in #11783