Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore - update resource azurerm_machine_learning_workspace to use auto-generated parsers and validators #11738

Closed

Conversation

gro1m
Copy link
Contributor

@gro1m gro1m commented May 16, 2021

This PR makes updates the current azurerm_machine_learning_workspace resource with using the capability to auto-generate the parsers and validators.
This could have the maybe unwanted side-effect of dropping parsing of azure container registry and azure storage account validations. To be assessed by the reviewer and maybe small changes could improve this still a bit:)

Test should still pass:

TF_ACC=1 go test -v ./azurerm/internal/services/machinelearning -run=TestAccMachineLearningWorkspace -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/05/16 16:15:25 [DEBUG] not using binary driver name, it's no longer needed
2021/05/16 16:15:25 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccMachineLearningWorkspaceDataSource_basic
=== PAUSE TestAccMachineLearningWorkspaceDataSource_basic
=== RUN   TestAccMachineLearningWorkspace_basic
=== PAUSE TestAccMachineLearningWorkspace_basic
=== RUN   TestAccMachineLearningWorkspace_requiresImport
=== PAUSE TestAccMachineLearningWorkspace_requiresImport
=== RUN   TestAccMachineLearningWorkspace_basicUpdate
=== PAUSE TestAccMachineLearningWorkspace_basicUpdate
=== RUN   TestAccMachineLearningWorkspace_complete
=== PAUSE TestAccMachineLearningWorkspace_complete
=== RUN   TestAccMachineLearningWorkspace_completeUpdate
=== PAUSE TestAccMachineLearningWorkspace_completeUpdate
=== CONT  TestAccMachineLearningWorkspaceDataSource_basic
=== CONT  TestAccMachineLearningWorkspace_requiresImport
=== CONT  TestAccMachineLearningWorkspace_completeUpdate
=== CONT  TestAccMachineLearningWorkspace_complete
=== CONT  TestAccMachineLearningWorkspace_basic
=== CONT  TestAccMachineLearningWorkspace_basicUpdate
2021/05/16 16:15:31 [DEBUG] Determining which Resource Providers require Registration
2021/05/16 16:15:31 [DEBUG] All required Resource Providers are registered
2021/05/16 16:15:31 [DEBUG] TF_ACCTEST_REATTACH set to 1 and acctest.TestHelper is not nil, using reattach-based testing
2021/05/16 16:19:00 [DEBUG] TF_ACCTEST_REATTACH set to 1 and acctest.TestHelper is not nil, using reattach-based testing
2021/05/16 16:19:12 [DEBUG] TF_ACCTEST_REATTACH set to 1 and acctest.TestHelper is not nil, using reattach-based testing
--- PASS: TestAccMachineLearningWorkspaceDataSource_basic (358.17s)
--- PASS: TestAccMachineLearningWorkspace_basic (359.21s)
--- PASS: TestAccMachineLearningWorkspace_complete (364.12s)
--- PASS: TestAccMachineLearningWorkspace_requiresImport (369.95s)
--- PASS: TestAccMachineLearningWorkspace_basicUpdate (397.91s)
--- PASS: TestAccMachineLearningWorkspace_completeUpdate (401.94s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/machinelearning     406.857s

@ghost ghost added size/XL and removed size/XXL labels May 16, 2021
@gro1m
Copy link
Contributor Author

gro1m commented May 16, 2021

Closed in favor of #11739 (the same just without cluttering commits)

@gro1m gro1m closed this May 16, 2021
@gro1m gro1m deleted the chore/update_machine_learning_workspace branch May 16, 2021 15:55
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant