Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_monitor_diagnostic_setting - Support dynamic block from unprovisioned data source for log/metric #11342

Closed

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 15, 2021

This PR mainly remove the default value for log/metirc's enabled (which is apparently a breaking change), in order to allow dynamic block which based on some unprovisioned data source, e.g. azurerm_monitor_diagnostic_categories whose resource_id set to some to-be-provisioned resource.

Due to hashicorp/terraform#28340, currently all we can do is to not alter the block data during planning if compatibility with the dynamic feature was desired. In this case, we shall not set the default value.

Fixes #9923, #6254

@magodo
Copy link
Collaborator Author

magodo commented May 6, 2021

Close due to hashicorp/terraform#28340 is fixed in TF v0.15.2.

@magodo magodo closed this May 6, 2021
@github-actions
Copy link

github-actions bot commented Jun 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with azurerm_monitor_diagnostic_setting and dynamic inline blocks
1 participant